New issue
Advanced search Search tips

Issue 736158 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[TTS] Update ukm.xml with new camel-case names

Project Member Reported by donnd@google.com, Jun 23 2017

Issue description

The current ukm.xml has all upper-case names for metrics, but we landed a CL in M-61 that uses camel-case names.  We need to update ukm.xml to reflect the new names.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 12 2017

Labels: Hotlist-Google

Comment 2 by donnd@chromium.org, Jul 13 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f20512d8a5b80fc23bcf7ae0eeccae20a02ac1a

commit 1f20512d8a5b80fc23bcf7ae0eeccae20a02ac1a
Author: Donn Denman <donnd@google.com>
Date: Fri Jul 14 18:58:08 2017

[TTS] Update Contextual Search UKM metric names.

Updates ukm.xml to have the correct metric names.
We originally wrote metrics using all-caps names,
and changed the code in CL 2894913003 but we forgot
to update ukm.xml at that time.

This just updates the ukm.xml names to reflect what's
already being written. Also removed one name that's
for data that's not actually written.

Also removes an include that's not needed.

BUG= 736158 

Change-Id: I31f94553ab188e7001d10a3f2f109e4d7a255233
Reviewed-on: https://chromium-review.googlesource.com/568760
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486823}
[modify] https://crrev.com/1f20512d8a5b80fc23bcf7ae0eeccae20a02ac1a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLoggerImpl.java
[modify] https://crrev.com/1f20512d8a5b80fc23bcf7ae0eeccae20a02ac1a/tools/metrics/ukm/ukm.xml

Comment 4 by donnd@chromium.org, Jul 14 2017

Status: Fixed (was: Started)

Sign in to add a comment