--unsafely-treat-insecure-origin-as-secure flag does not impact content::IsOriginSecure checks in the renderer |
|||||||
Issue descriptionWhat steps will reproduce the problem? (1) Run chrome with --unsafely-treat-insecure-origin-as-secure=http://www.testwebcam.com (2) Go to http://www.testwebcam.com (3) Allow Flash, note that camera and mic aren't allowed. This will cause an error message to be displayed in the console. The problem here is that the global variable in the renderer which stores the secure origins passed in via the flag is initialized while the process is still a zygote process. Currently we do not propagate the flag to zygote processes, so the values are never initialized correctly.
,
Jun 22 2017
mkwst/palmer: do you have thoughts on the behavior in this case?
,
Jun 26 2017
,
Jun 26 2017
,
Jun 26 2017
I worked this out, this was actually a bug specific to the checks I added because they use content::IsOriginSecure in the renderer process, which is currently buggy on linux. I've got a patch: https://codereview.chromium.org/2955803002
,
Jun 26 2017
+elawrence as FYI
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/998231b917858c87b641040c742f5cc41ac9b43e commit 998231b917858c87b641040c742f5cc41ac9b43e Author: raymes <raymes@chromium.org> Date: Mon Jun 26 19:29:25 2017 Propogate kUnsafelyTreatInsecureOriginAsSecure flag to the zygote process ChromeContentClient::AddAdditionalSchemes sets up the global whitelisted origins. Some of these origins may be passed in via the kUnsafelyTreatInsecureOriginsAsSecure flag. However, this call happens while the renderer process is still a zygote on linux. This means that content::IsOriginSecure checks won't take these whitelisted origins into account. BUG= 736140 Review-Url: https://codereview.chromium.org/2955803002 Cr-Commit-Position: refs/heads/master@{#482353} [modify] https://crrev.com/998231b917858c87b641040c742f5cc41ac9b43e/chrome/browser/chrome_content_browser_client.cc
,
Jun 26 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by raymes@chromium.org
, Jun 22 2017