New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736124 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Stop including Polymer testing related files along in production binary.

Project Member Reported by dpa...@chromium.org, Jun 22 2017

Issue description

I have a CL that does this at https://codereview.chromium.org/2949313002. Updated all WebUI tests accordingly, but it requires some more work to get the PDFExtensionTest to work [1]. Essentially instead of accessing mock-interactions.js [2] from a chrome:// URL it should be made available otherwise only during testing.

@pdf OWNERS: Any ideas on how to include mock-interactions.js during testing? 

[1] https://cs.chromium.org/chromium/src/chrome/browser/pdf/pdf_extension_test.cc
[2] https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/iron-test-helpers/mock-interactions.js



 

Comment 1 by dpa...@chromium.org, Jun 23 2017

Figured out how to load mock-interactions.js alternatively during PDFExtensionTest, see https://codereview.chromium.org/2949883006.

Comment 2 by dpa...@chromium.org, Jun 23 2017

Cc: tsergeant@chromium.org

Comment 4 by dpa...@chromium.org, Jun 26 2017

Status: Fixed (was: Started)
https://codereview.chromium.org/2949313002 also refers to this bug, but was not marked appropriately.

Sign in to add a comment