New issue
Advanced search Search tips

Issue 736102 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Merge requirePageReconstruction with reinitializeWebViewAndReload

Project Member Reported by liaoyuke@chromium.org, Jun 22 2017

Issue description

In crw_web_controller, Merge requirePageReconstruction with reinitializeWebViewAndReload, they are currently subtly different in terms of implementation, but are for fundamentally the same purpose.
 
Status: Available (was: Untriaged)
Status: Assigned (was: Available)
I'm going to kill reinitializeWebViewAndReload: and replace the call with public ios/web API.
Cc: -eugene...@chromium.org
Owner: eugene...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca45889993ebd4a1ea386295f5c80795891dfd76

commit ca45889993ebd4a1ea386295f5c80795891dfd76
Author: Eugene But <eugenebut@google.com>
Date: Tue Aug 08 22:03:34 2017

Removed -[CRWWebController reinitializeWebViewAndReload:].

WebViews can be purged by disabling and enabling back web usage.
Also removed all code which depended on reinitializeWebViewAndReload.

Bug:  736102 ,620480
Change-Id: Ib52e2a700390d87e07054bf48834c23f71e68333
Reviewed-on: https://chromium-review.googlesource.com/602782
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492758}
[modify] https://crrev.com/ca45889993ebd4a1ea386295f5c80795891dfd76/ios/chrome/browser/tabs/tab_model.h
[modify] https://crrev.com/ca45889993ebd4a1ea386295f5c80795891dfd76/ios/chrome/browser/tabs/tab_model.mm
[modify] https://crrev.com/ca45889993ebd4a1ea386295f5c80795891dfd76/ios/chrome/browser/web/visible_url_egtest.mm
[modify] https://crrev.com/ca45889993ebd4a1ea386295f5c80795891dfd76/ios/chrome/test/app/chrome_test_util.h
[modify] https://crrev.com/ca45889993ebd4a1ea386295f5c80795891dfd76/ios/chrome/test/app/chrome_test_util.mm
[modify] https://crrev.com/ca45889993ebd4a1ea386295f5c80795891dfd76/ios/web/web_state/ui/crw_web_controller.h
[modify] https://crrev.com/ca45889993ebd4a1ea386295f5c80795891dfd76/ios/web/web_state/ui/crw_web_controller.mm

Status: Fixed (was: Assigned)

Sign in to add a comment