Here is the regression range https://chromium.googlesource.com/chromium/src/+log/206f5f0fcdd4809a342fdde6dbcfa24d2dbc306f..eba855f22deff3a00b76384582808925841f4be5

Looks like https://chromium-review.googlesource.com/c/534833 has caused this.

estade@: Can you please take a look?

If the new Toolbar bottom border colour is intentional, may be it could be possible to change the Omnibox Dropdown Top border colour to match it with the new Toolbar bottom border color?

estade@/shrike@: What do you think?

If we can live with it, please feel free to close this issue.

Thanks :-)

tapted@ - is this related to your recent bookmarks bar border color fix or a different issue with estade@'s original change?

it's a different issue.

Cocoa's theming seems to ignore ThemeProperties::COLOR_TOOLBAR_BOTTOM_SEPARATOR and ThemeProperties::COLOR_LOCATION_BAR_BORDER -- we don't reference those in Cocoa or cross-platform code, only under chrome/browser/ui/views

The popup background color on Mac is hardcoded:

NSColor* OmniboxPopupViewMac::BackgroundColor(bool is_dark_theme) {
  const CGFloat kMDDarkControlBackround = 40 / 255.;
  return is_dark_theme
             ? [NSColor colorWithGenericGamma22White:kMDDarkControlBackround
                                               alpha:1]
             : [NSColor controlBackgroundColor];
}

But -[BackgroundGradientView strokeColor] seems to arbitrarily pick ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_SEPARATOR and use it for lots of things.

On views, the omnibox popup seems to use NativeTheme::kColorId_ResultsTableNormalBackground for its background.

Fixing this in the Cocoa browser in the wrong place to start -- there's no attempt on other platforms to make the colors in this bug description the same. (it even shifts up a pixel on Windows :/).

The only way to fix this on Mac separately would be to hardcode colors in more places to match OmniboxPopupViewMac::BackgroundColor(..) so that the theme is ignored consistently. There's a scary thread in Issue 621004 about all this...

If these should always match, then someone needs to first decide whether we should allow the omnibox popup to be themable, stop using NativeTheme::kColorId_ResultsTableNormalBackground there, and either rename ThemeProperties::COLOR_TOOLBAR_BOTTOM_SEPARATOR to ThemeProperties::COLOR_TOOLBAR_BOTTOM_SEPARATOR_AND_OMNIBOX_POPUP_BACKGROUND or add a new theme property for the omnibox popup.

I don't think any of this is high priority. It's probably blocked on a resolution of Issue 621004 to decide whether we want the omnibox popup to match the theme, which is currently providing the toolbar separator but has no influence on the omnibox popup.

Switching to P-3 per "I don't think any of this is high priority."

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue will be obsolete with MdRefresh. Please feel free to close this report. Thanks.