Is this a work item? Is there someone to whom this is supposed to be assigned?

I can tentatively assign myself, since I have a WIP CL in flight to convert these to be more consistent with Harmony UI.

We left this untriaged because we don't know who should own it, but yes, someone should fix it.

[MacTriage] back to csharrison@, who volunteered to fix.

Let's move this back to untriaged. After Bret's comment here [1] I'm not sure if there is a pressing need to fix this for non-Views based UI. Bret can you elaborate on your comment?

[1]: https://chromium-review.googlesource.com/c/544199/4/chrome%252Fbrowser%252Fui%252Fcocoa%252Fsubresource_filter%252Fsubresource_filter_bubble_controller.mm#67

Right now we're working on getting mac to use views rather than cocoa. That's about all I know; +ellyjones who has more details.

ellyjones@ - would you please take this one? We want the link to show up in the current UI (we don't know what the ETA is for MacViews secondary ui).

Cocoa screenshot attached.

Deleted: Screen Shot 2017-07-10 at 12.27.34 PM.png 16.9 KB

	Screen Shot 2017-07-10 at 12.27.34 PM.png 16.9 KB View Download

Views screenshot for reference

Deleted: linux-flash.png 10.2 KB

	linux-flash.png 10.2 KB View Download

Can you replace the button with a HyperLinkTextView, so that the control is a link?

I have not changed anything yet - do you mean the Manage button? If so, I can change it, yeah.

Sorry, confused for a moment. I think leave the Manage plugin button as is (before I was saying to change it), and just add the Learn more link (and please double-check that it increments the PLUGINS_ACTION_CLICKED_LEARN_MORE histogram).

I redid this UI in <https://chromium-review.googlesource.com/c/568359>. Screenshots attached:

1-plugin-mandatory: appearance of the new bubble when one plugin was blocked and the block is mandatory (the "normal" appearance of this bubble)

1-plugin-optional: appearance when the block can be overridden - I'm not 100% positive this can happen these days, because the block is exposed through the new content settings bubble, but the model still supports this configuration

2-plugins-mandatory: appearance when there are two plugins blocked - I'm not positive *this* can happen either, since we have only 1 plugin these days :) but included for completeness

Deleted: 1-plugin-mandatory.png 20.1 KB

	1-plugin-mandatory.png 20.1 KB View Download

Deleted: 1-plugin-optional.png 21.8 KB

	1-plugin-optional.png 21.8 KB View Download

Deleted: 2-plugins-mandatory.png 21.1 KB

	2-plugins-mandatory.png 21.1 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/134fcc124a4b00378b0b52cb57bf390a1652da06

commit 134fcc124a4b00378b0b52cb57bf390a1652da06
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Wed Jul 19 14:46:39 2017

cocoa: replace blocked plugin bubble xib

This change replaces the blocked plugin bubble (the one shown when the user
clicks on the blocked-plugin decoration in the omnibox) with a new
implementation. The new bubble includes the missing "Learn More" link and has
a more consistent visual layout. This change also deletes the old xib.

Bug:  736076 
Change-Id: I2c45f6684d4b090941b1f964570a7cebfaffa7eb
Reviewed-on: https://chromium-review.googlesource.com/568359
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487857}
[modify] https://crrev.com/134fcc124a4b00378b0b52cb57bf390a1652da06/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/d668cd5b0067c252e8c83d826a213d2d776b5c39/chrome/app/nibs/ContentBlockedPlugins.xib
[modify] https://crrev.com/134fcc124a4b00378b0b52cb57bf390a1652da06/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/134fcc124a4b00378b0b52cb57bf390a1652da06/chrome/browser/ui/cocoa/content_settings/blocked_plugin_bubble_controller.h
[add] https://crrev.com/134fcc124a4b00378b0b52cb57bf390a1652da06/chrome/browser/ui/cocoa/content_settings/blocked_plugin_bubble_controller.mm
[modify] https://crrev.com/134fcc124a4b00378b0b52cb57bf390a1652da06/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm
[modify] https://crrev.com/134fcc124a4b00378b0b52cb57bf390a1652da06/ui/base/cocoa/controls/textfield_utils.mm

This is done now.