New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736075 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Avoid logging certain errors for non main frames.

Project Member Reported by bmcquade@chromium.org, Jun 22 2017

Issue description

Avoid logging certain errors for non main frames.

ERR_IPC_WITH_NO_RELEVANT_LOAD and ERR_IPC_FROM_BAD_URL_SCHEME are
errors that help to understand when we receive messages from a
render process that aren't expected in the browser process.

Historically, we only tracked main frames, so it made sense to
log these on all IPCs.

As of https://codereview.chromium.org/2859393002, we receive
IPCs from both main and child frames.

It is valid and expected to receive these IPCs from a child
frame when we aren't tracking a main frame, as render tracking
policy is purely per frame and has no awareness of the main
frame's URL etc.

Thus, we update the code that logs these errors to only do so
for messages received from main frames.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a264f3ff6535a674c6ef1555952832a6cc2fd21

commit 9a264f3ff6535a674c6ef1555952832a6cc2fd21
Author: Bryan McQuade <bmcquade@chromium.org>
Date: Thu Jun 22 21:20:40 2017

Avoid logging certain errors for non main frames.

ERR_IPC_WITH_NO_RELEVANT_LOAD and ERR_IPC_FROM_BAD_URL_SCHEME are
errors that help to understand when we receive messages from a
render process that aren't expected in the browser process.

Historically, we only tracked main frames, so it made sense to
log these on all IPCs.

As of https://codereview.chromium.org/2859393002, we receive
IPCs from both main and child frames.

It is valid and expected to receive these IPCs from a child
frame when we aren't tracking a main frame, as render tracking
policy is purely per frame and has no awareness of the main
frame's URL etc.

Thus, we update the code that logs these errors to only do so
for messages received from main frames.

Bug:  736075 
Change-Id: Ifc7f2dd758fc244de8e7098a3c553f8bb2ad05ee
Reviewed-on: https://chromium-review.googlesource.com/545016
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481666}
[modify] https://crrev.com/9a264f3ff6535a674c6ef1555952832a6cc2fd21/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Status: Fixed (was: Started)

Sign in to add a comment