New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736070 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Remove Draw[Arrays|Elements]Instanced divisor limitation in WebGL2

Project Member Reported by zmo@chromium.org, Jun 22 2017

Issue description

Due to D3D9 limitation, WebGL1's instanced extension required at least one vertex attrib to have a zero divisor. Such limitation no longer exists in D3D11 and should not be in WebGL2.
 

Comment 1 by zmo@chromium.org, Jun 22 2017

Conformance test update: https://github.com/KhronosGroup/WebGL/pull/2424/
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/279ae138790e2ba909d0229c1e429ffffda8578f

commit 279ae138790e2ba909d0229c1e429ffffda8578f
Author: zmo <zmo@chromium.org>
Date: Fri Jun 23 18:52:19 2017

Remove WebGL2 constraint that requires draw*Instanced() calls to fail when no vertex attrib has zero divisor.

BUG= 736070 
TEST=https://github.com/KhronosGroup/WebGL/pull/2424
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2950423002
Cr-Commit-Position: refs/heads/master@{#481973}

[modify] https://crrev.com/279ae138790e2ba909d0229c1e429ffffda8578f/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/279ae138790e2ba909d0229c1e429ffffda8578f/gpu/command_buffer/service/vertex_attrib_manager.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7be4431e25e99b26dc68a89df81c48b2af74143c

commit 7be4431e25e99b26dc68a89df81c48b2af74143c
Author: zmo <zmo@chromium.org>
Date: Fri Jun 23 22:59:51 2017

Roll WebGL 331fe3a..9ffa3b5

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/331fe3a..9ffa3b5

BUG= 736070 , 696126 
TEST=bots
TBR=kbr@chromium.org
NOTRY=true

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2957683002
Cr-Commit-Position: refs/heads/master@{#482060}

[modify] https://crrev.com/7be4431e25e99b26dc68a89df81c48b2af74143c/DEPS
[modify] https://crrev.com/7be4431e25e99b26dc68a89df81c48b2af74143c/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/7be4431e25e99b26dc68a89df81c48b2af74143c/content/test/gpu/gpu_tests/webgl_conformance_revision.txt

Comment 4 by zmo@chromium.org, Jun 23 2017

Status: Fixed (was: Assigned)

Sign in to add a comment