We should remove unneeded and illegal enum forward declarations |
||
Issue descriptionForward declaring of enums without specifying a size is prohibited in C++. However VC++ allowed it for a long time so some crept in. Some of them (those that are also compiled for other platforms) are just unnecessary and can be deleted, to avoid confusion. Others (Windows only code) are wrong and need fixing.
,
Jun 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/5e5f7e14b23ee93fb163d64229da5ec5708f7cf9 commit 5e5f7e14b23ee93fb163d64229da5ec5708f7cf9 Author: brucedawson <brucedawson@chromium.org> Date: Sat Jun 24 20:04:29 2017 Remove unneeded enum forward declaration While building Chrome with the VC++ 2017 /permissive- flag I got a warning about a forward declaration of enum RateControlRegion. Untyped forward declarations of enums are illegal because the compiler doesn't know what size to make them. The only reason this forward declaration is legal is because it isn't needed (the type is already defined). This was found because /permissive- (or, equivalently for this purpose, /w14471) incorrectly fires on this forward declaration even though it is legal. BUG= chromium:736059 Review-Url: https://codereview.webrtc.org/2834753002 Cr-Commit-Position: refs/heads/master@{#18741} [modify] https://crrev.com/5e5f7e14b23ee93fb163d64229da5ec5708f7cf9/webrtc/modules/remote_bitrate_estimator/overuse_detector.h
,
Jun 27 2017
I'm not aware of anymore and we've landed a clang-cl warning (crrev.com/2955643002) that should keep things clean. |
||
►
Sign in to add a comment |
||
Comment 1 by brucedaw...@chromium.org
, Jun 22 2017