New issue
Advanced search Search tips

Issue 736056 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Many new wpt encoding tests time out, especially on Mac.

Project Member Reported by qyears...@chromium.org, Jun 22 2017

Issue description

Some tests in https://chromium-review.googlesource.com/c/543695/, specifically in external/wpt/encoding/legacy-mb-*, timed out in try jobs, mostly on Mac10.9, but also a few times on other try bots. They might be slow tests, or something might be hanging sometimes.

Example results:
https://storage.googleapis.com/chromium-layout-test-archives/mac10_9_blink_rel/2889/layout-test-results/test-expectations.html
 
Labels: TE-NeedsTriageHelp
As it is builds related issue,could some one from dev team please look into this issue.
Adding 'TE-NeedsTriagehelp' label for further investigation.
Thanks..!!
Cc: jsb...@chromium.org
Tests that are marked as flaky timeout:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/TestExpectations?q=736056&sq=package:chromium&dr=C&l=1919

Flakiness dashboard shows that these tests consistently time out on Mac 10.9 but no other platforms:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=external/wpt/encoding/legacy-mb-japanese
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=external%2Fwpt%2Fencoding%2Flegacy-mb-korean
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=external/wpt/encoding/legacy-mb-tchinese

These tests are in wpt/encoding, and jsbell@ is marked as the OWNER of this directory.

Joshua, since this is just on Mac10.9, and they seem to be slow-ish tests anyway on other platforms, maybe they should just be marked as Slow on Mac10.9 in SlowTests? WDYT?
Actually a bunch of the external/wpt/encoding/legacy-mb-korean tests time out on other mac platforms too; they should maybe be marked as slow in general, or on Mac in particular.
Slow in general is fine - they do a lot of churning.

Hrm.. they do have <meta name="timeout" content="long"> - are we not honoring that?

Cc: -jsb...@chromium.org qyears...@chromium.org
Owner: jsb...@chromium.org
Status: Assigned (was: Unconfirmed)
Components: Blink>TextEncoding
Good question -- we *should* be honoring <meta name="timeout"...>, if https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_manifest.py?l=65 is working right...
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fef5260747292cd3e2c96c5f4c5652c4a7c1c11c

commit fef5260747292cd3e2c96c5f4c5652c4a7c1c11c
Author: Joshua Bell <jsbell@chromium.org>
Date: Thu Jul 06 21:40:48 2017

WPT: Mark external/wpt/encoding/legacy tests as slow

These imported tests exercise the full character range of legacy
encodings, and generate large results, which can be slow.

Particularly on Mac 10.9 the tests have been timing out, but they
are known slowish everywhere.

Bug:  736056 
Change-Id: I0ec1e061168df56bcf4cd11e95b490ae6788fcfa
Reviewed-on: https://chromium-review.googlesource.com/562317
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484748}
[modify] https://crrev.com/fef5260747292cd3e2c96c5f4c5652c4a7c1c11c/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/fef5260747292cd3e2c96c5f4c5652c4a7c1c11c/third_party/WebKit/LayoutTests/TestExpectations

 Issue 757292  has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5102cfdc5301add2fcf8496216ffdbeb0e88d492

commit 5102cfdc5301add2fcf8496216ffdbeb0e88d492
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Mon Aug 21 15:33:12 2017

Expect external/wpt/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-errors-han.html to timeout on Win7

It has started to timeout consistently lately, starting with
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10570

BUG= 736056 
TBR=jsbell@chromium.org

Change-Id: I6390462119ac842da070c683454e9760cae74315
Reviewed-on: https://chromium-review.googlesource.com/623708
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495942}
[modify] https://crrev.com/5102cfdc5301add2fcf8496216ffdbeb0e88d492/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c88083dcc024bfbf979b36a186ba781456b53612

commit c88083dcc024bfbf979b36a186ba781456b53612
Author: Robert Ma <robertma@chromium.org>
Date: Wed Dec 20 22:12:20 2017

Simplify platform specifiers of some expectations

Most of these were artifacts when we fiddled with platform specifier
simplification or when Mac10.13 was newly added.

Also change the linked bug of an encoding test to the more specific one.

Bug:  736056 ,  796617 
Change-Id: I86fa7980eee86790503d62d7368a745da08a905f
Reviewed-on: https://chromium-review.googlesource.com/837680
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525489}
[modify] https://crrev.com/c88083dcc024bfbf979b36a186ba781456b53612/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0866e5a8e7fe0450699c18b73c8be109f01bd119

commit 0866e5a8e7fe0450699c18b73c8be109f01bd119
Author: Joshua Bell <jsbell@chromium.org>
Date: Mon Jan 29 18:48:12 2018

Timeout expectations for wpt/encoding/legacy-mb-* tests

Consolidate expectations for the imported Web Platform Tests for
legacy multibyte encodings (Chinese, Japanese, Korean) which exercise
tens of thousands of code points and often time out (>30s) even when
marked as slow.

TBR=kbr@chromium.org

Bug:  805725 , 736056 , 749070 
Change-Id: I12051e3c3a20730783aabb39376b55e9788450f4
Reviewed-on: https://chromium-review.googlesource.com/889538
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532512}
[modify] https://crrev.com/0866e5a8e7fe0450699c18b73c8be109f01bd119/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16a0d067a69bbef81cb94bc4fe154cac36a85571

commit 16a0d067a69bbef81cb94bc4fe154cac36a85571
Author: Robert Ma <robertma@chromium.org>
Date: Mon Jun 11 14:34:23 2018

Unskip external/wpt/encoding tests

The tests have been split in the upstream and should no longer time out:
https://github.com/web-platform-tests/wpt/pull/11016
https://github.com/web-platform-tests/wpt/pull/11292

Bug:  736056 
Change-Id: I2267ffb05e8c74c5d70bd6d8a4020bb24c78bd0c
Reviewed-on: https://chromium-review.googlesource.com/1081123
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565995}
[modify] https://crrev.com/16a0d067a69bbef81cb94bc4fe154cac36a85571/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment