New issue
Advanced search Search tips

Issue 736054 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove loader_kernel initramfs environment

Project Member Reported by ddavenp...@chromium.org, Jun 22 2017

Issue description

It's no longer in use and doesn't build correctly for all architectures.
 
Owner: ddavenp...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/884a1db67342b6f3e2242851af712bf98d85eadc

commit 884a1db67342b6f3e2242851af712bf98d85eadc
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri Jun 23 20:54:24 2017

Revert "cros-kernel2.eclass: remove loader_kernel_ramfs"

This reverts commit 0d7dfa0e45e283dc57cce238037926ab0b82e81f.

Reason for revert: A completely speculative revert for  crbug.com/736473 
Really, I'm out of ideas. Accept my apologies.

Original change's description:
> cros-kernel2.eclass: remove loader_kernel_ramfs
> 
> loader_kernel is no longer used, so remove references to
> USE=loader_kernel_ramfs
> 
> BUG= chromium:736054 
> TEST=emerge-x86-generic chromeos-kernel-4_4
> TEST=trybots
> 
> Change-Id: Ida540fe85705b2867abf88d8f50e66cc8f2271fc
> Reviewed-on: https://chromium-review.googlesource.com/544801
> Commit-Ready: Drew Davenport <ddavenport@chromium.org>
> Tested-by: Drew Davenport <ddavenport@chromium.org>
> Reviewed-by: Mike Frysinger <vapier@chromium.org>

BUG= chromium:736473 

Change-Id: I599365bab97aca6511ee799d360ec418a45a3061
Reviewed-on: https://chromium-review.googlesource.com/546875
Reviewed-by: Drew Davenport <ddavenport@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/884a1db67342b6f3e2242851af712bf98d85eadc/eclass/cros-kernel2.eclass

Comment 3 by sjg@google.com, Jul 5 2017

Labels: Team-BLD
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7d67204a9f489da3a12bd5e179101bf909438c8a

commit 7d67204a9f489da3a12bd5e179101bf909438c8a
Author: Drew Davenport <ddavenport@chromium.org>
Date: Thu Jul 06 04:54:49 2017

Reland "cros-kernel2.eclass: remove loader_kernel_ramfs"

- Included a trivial change to the .ebuild files that inherit
  from cros-kernel2.eclass to ensure that they get uprevved.

This is a reland of 0d7dfa0e45e283dc57cce238037926ab0b82e81f
Original change's description:
> cros-kernel2.eclass: remove loader_kernel_ramfs
>
> loader_kernel is no longer used, so remove references to
> USE=loader_kernel_ramfs
>
> BUG= chromium:736054 
> TEST=emerge-x86-generic chromeos-kernel-4_4
> TEST=trybots
>
> Change-Id: Ida540fe85705b2867abf88d8f50e66cc8f2271fc
> Reviewed-on: https://chromium-review.googlesource.com/544801
> Commit-Ready: Drew Davenport <ddavenport@chromium.org>
> Tested-by: Drew Davenport <ddavenport@chromium.org>
> Reviewed-by: Mike Frysinger <vapier@chromium.org>

BUG= chromium:736054 
TEST=remote trybuild with hwtests on cave and caroline

Change-Id: Ia24d1499cf6afbe0c583bbe52cffa9e7d0cb84ba
Reviewed-on: https://chromium-review.googlesource.com/549977
Commit-Ready: Drew Davenport <ddavenport@chromium.org>
Tested-by: Drew Davenport <ddavenport@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/7d67204a9f489da3a12bd5e179101bf909438c8a/sys-kernel/upstream-kernel-mainline/upstream-kernel-mainline-9999.ebuild
[modify] https://crrev.com/7d67204a9f489da3a12bd5e179101bf909438c8a/sys-kernel/chromeos-kernel-3_8/chromeos-kernel-3_8-9999.ebuild
[modify] https://crrev.com/7d67204a9f489da3a12bd5e179101bf909438c8a/sys-kernel/chromeos-kernel-3_10/chromeos-kernel-3_10-9999.ebuild
[modify] https://crrev.com/7d67204a9f489da3a12bd5e179101bf909438c8a/sys-kernel/chromeos-kernel-3_18/chromeos-kernel-3_18-9999.ebuild
[modify] https://crrev.com/7d67204a9f489da3a12bd5e179101bf909438c8a/sys-kernel/upstream-kernel-next/upstream-kernel-next-9999.ebuild
[modify] https://crrev.com/7d67204a9f489da3a12bd5e179101bf909438c8a/eclass/cros-kernel2.eclass
[modify] https://crrev.com/7d67204a9f489da3a12bd5e179101bf909438c8a/sys-kernel/chromeos-kernel-3_14/chromeos-kernel-3_14-9999.ebuild
[modify] https://crrev.com/7d67204a9f489da3a12bd5e179101bf909438c8a/sys-kernel/chromeos-kernel-4_4/chromeos-kernel-4_4-9999.ebuild

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9fbf6838ec0550caf26c7a525a0847fc7ce71843

commit 9fbf6838ec0550caf26c7a525a0847fc7ce71843
Author: Drew Davenport <ddavenport@chromium.org>
Date: Thu Jul 06 16:49:25 2017

initramfs: Remove loader_kernel

loader_kernel is no longer in use, so remove it.

BUG= chromium:736054 
TEST=initramfs/test/test.sh runs
TEST=trybots
CQ-DEPEND=CL:549977

Change-Id: I9d347b5831c7882664b1bd504256795c128dbf5a
Reviewed-on: https://chromium-review.googlesource.com/545109
Commit-Ready: Drew Davenport <ddavenport@chromium.org>
Tested-by: Drew Davenport <ddavenport@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/9fbf6838ec0550caf26c7a525a0847fc7ce71843/chromeos-base/chromeos-initramfs/chromeos-initramfs-9999.ebuild

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/initramfs/+/dacf40b3c932d3e68ba1146b1f3b0e2497fb6831

commit dacf40b3c932d3e68ba1146b1f3b0e2497fb6831
Author: Drew Davenport <ddavenport@chromium.org>
Date: Thu Jul 06 19:12:06 2017

initramfs: Remove loader_kernel environment

loader_kernel is no longer used, so remove it.

BUG= chromium:736054 
TEST=test/test.sh runs
TEST=trybots
CQ-DEPEND=CL:545109

Change-Id: I27d5ae2f4458c91a8c7c02749fb4efd9e5b48cc1
Reviewed-on: https://chromium-review.googlesource.com/545107
Commit-Ready: Drew Davenport <ddavenport@chromium.org>
Tested-by: Drew Davenport <ddavenport@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/3b5a5598ce95f11fcd1356dc599cb3b1d121f792/loader_kernel/init
[delete] https://crrev.com/3b5a5598ce95f11fcd1356dc599cb3b1d121f792/loader_kernel/Makefile
[modify] https://crrev.com/dacf40b3c932d3e68ba1146b1f3b0e2497fb6831/test/qemu
[delete] https://crrev.com/3b5a5598ce95f11fcd1356dc599cb3b1d121f792/loader_kernel/README.md

Status: Fixed (was: Assigned)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment