Hit DCHECK in AppBannerManager |
||||
Issue descriptionThis was with a debug build @ f43e59e39557ee55c2d74d600a10c0d61ae17e36 (481305). I tried to install an app from the app store and hit this DCHECK. This is a chromeos build: #0 0x7fbe522adb7b base::debug::StackTrace::StackTrace() #1 0x7fbe522ac8bc base::debug::StackTrace::StackTrace() #2 0x7fbe523192e7 logging::LogMessage::~LogMessage() #3 0x560eb6df596c banners::AppBannerManager::RequestAppBanner() #4 0x560eb6df8755 banners::AppBannerManager::OnEngagementIncreased() #5 0x560ebaad814c banners::AppBannerManagerDesktop::OnEngagementIncreased() #6 0x560eb69cb641 SiteEngagementService::HandleUserInput() #7 0x560eb6d1d158 SiteEngagementService::Helper::RecordUserInput() #8 0x560eb6d1cf7d SiteEngagementService::Helper::InputTracker::DidGetUserInteraction() #9 0x7fbe4c302e36 content::WebContentsImpl::OnUserInteraction() #10 0x7fbe4c0062c9 content::RenderWidgetHostImpl::FilterInputEvent() #11 0x7fbe4be53f46 content::LegacyInputRouterImpl::OfferToClient() #12 0x7fbe4be53e4b content::LegacyInputRouterImpl::OfferToHandlers() #13 0x7fbe4be51f3b content::LegacyInputRouterImpl::FilterAndSendWebInputEvent() #14 0x7fbe4be5259e content::LegacyInputRouterImpl::SendMouseEventImmediately() #15 0x7fbe4be51ac2 content::LegacyInputRouterImpl::SendMouseEvent() #16 0x7fbe4c001d11 content::RenderWidgetHostImpl::ForwardMouseEventWithLatencyInfo() #17 0x7fbe4c034bcc content::RenderWidgetHostViewAura::ProcessMouseEvent() #18 0x7fbe4c0231cf content::RenderWidgetHostInputEventRouter::RouteMouseEvent() #19 0x7fbe4c4997f8 content::RenderWidgetHostViewEventHandler::OnMouseEvent() #20 0x7fbe4c034956 content::RenderWidgetHostViewAura::OnMouseEvent() #21 0x7fbe489eb123 ui::EventHandler::OnEvent() #22 0x7fbe489e6ec0 ui::EventDispatcher::DispatchEvent() #23 0x7fbe489e681b ui::EventDispatcher::ProcessEvent() #24 0x7fbe489e65b2 ui::EventDispatcherDelegate::DispatchEventToTarget() #25 0x7fbe489e6492 ui::EventDispatcherDelegate::DispatchEvent() #26 0x7fbe489ebf51 ui::EventProcessor::OnEventFromSource() #27 0x7fbe489ec09c ui::EventProcessor::OnEventFromSource() #28 0x7fbe489eced5 ui::EventSource::DeliverEventToSink() #29 0x7fbe489ecb4c ui::EventSource::SendEventToSink() #30 0x7fbe43249524 ash::AshWindowTreeHostPlatform::DispatchEvent() #31 0x7fbe35369b45 _ZN4base8internal13FunctorTraitsIMN2ui22PlatformWindowDelegateEFvPNS2_5EventEEvE6InvokeIPS3_JS5_EEEvS7_OT_DpOT0_ #32 0x7fbe35369a56 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN2ui22PlatformWindowDelegateEFvPNS4_5EventEEJPS5_S7_EEEvOT_DpOT0_ #33 0x7fbe353699e7 _ZN4base8internal7InvokerINS0_9BindStateIMN2ui22PlatformWindowDelegateEFvPNS3_5EventEEJNS0_17UnretainedWrapperIS4_EEEEEFvS6_EE7RunImplIRKS8_RKSt\ 5tupleIJSA_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOS6_ #34 0x7fbe353698ec _ZN4base8internal7InvokerINS0_9BindStateIMN2ui22PlatformWindowDelegateEFvPNS3_5EventEEJNS0_17UnretainedWrapperIS4_EEEEEFvS6_EE3RunEPNS0_13BindSt\ ateBaseEOS6_ #35 0x7fbe489f56e2 _ZNKR4base8CallbackIFvPN2ui5EventEELNS_8internal8CopyModeE1ELNS5_10RepeatModeE1EE3RunES3_ #36 0x7fbe489f553e ui::DispatchEventFromNativeUiEvent() #37 0x7fbe3536924e ui::X11WindowOzone::DispatchEvent() #38 0x7fbe5077ffbd ui::PlatformEventSource::DispatchEvent() #39 0x7fbe353c339b ui::X11EventSourceLibevent::ProcessXEvent() #40 0x7fbe353b4f18 ui::X11EventSource::ExtractCookieDataDispatchEvent() #41 0x7fbe353b4e97 ui::X11EventSource::DispatchXEvents() #42 0x7fbe353c389f ui::X11EventSourceLibevent::OnFileCanReadWithoutBlocking() #43 0x7fbe52353871 base::MessagePumpLibevent::FileDescriptorWatcher::OnFileCanReadWithoutBlocking() #44 0x7fbe52354921 base::MessagePumpLibevent::OnLibeventNotification() #45 0x7fbe52599bfe event_process_active #46 0x7fbe52599247 event_base_loop #47 0x7fbe52354a06 base::MessagePumpLibevent::Run() #48 0x7fbe52341a63 base::MessageLoop::Run() #49 0x7fbe523e1707 base::RunLoop::Run() #50 0x560eb639d6b6 ChromeBrowserMainParts::MainMessageLoopRun() #51 0x7fbe4b6597bb content::BrowserMainLoop::RunMainMessageLoopParts() #52 0x7fbe4b665195 content::BrowserMainRunnerImpl::Run() #53 0x7fbe4b6535c8 content::BrowserMain() #54 0x7fbe4cf64436 content::RunNamedProcessTypeMain() #55 0x7fbe4cf666df content::ContentMainRunnerImpl::Run() #56 0x7fbe4cf631fa content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #57 0x7fbe529d2e47 service_manager::Main() #58 0x7fbe4cf63f5b content::ContentMain() #59 0x560eb435a68c ChromeMain #60 0x560eb435a582 main #61 0x7fbe369d4f45 __libc_start_main Marking this a 1 as DCHECKs indicate something wrong is going on.
,
Jun 23 2017
Yes, I installed it from the app store. After I hit this I nuked my profile and it worked without hitting the DCHECK.
,
Jun 23 2017
I can't repro this, but I have a speculative idea of why it might be DCHECK failing. Will send a commit through shortly.
,
Jun 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/339d7dc9d0e5c64329105314a52413025b18b89c commit 339d7dc9d0e5c64329105314a52413025b18b89c Author: dominickn <dominickn@chromium.org> Date: Sat Jun 24 01:04:23 2017 Stop the banner pipeline from being triggered if it is already active. This is a speculative fix for crbug.com/736045 . If we tip over the engagement threshold while the app banner pipeline is active, and we've already started the banenr checking due to the onload experiment, we could get into a state where RequestAppBanner is called but we haven't stopped the previous run. This CL guards all calls to RequestAppBanner on the banner pipeline not being active. BUG= 736045 Review-Url: https://codereview.chromium.org/2958473002 Cr-Commit-Position: refs/heads/master@{#482103} [modify] https://crrev.com/339d7dc9d0e5c64329105314a52413025b18b89c/chrome/browser/banners/app_banner_manager.cc
,
Jun 26 2017
Tentatively marking as fixed.
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dominickn@chromium.org
, Jun 23 2017Labels: Needs-Feedback