New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736027 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----



Sign in to add a comment

Play Store app search by voice

Project Member Reported by hejq@chromium.org, Jun 22 2017

Issue description

Figure out whether we should have Play Store app search by voice input.

 

Comment 1 by hejq@chromium.org, Jul 20 2017

Components: UI>Shell>Launcher
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33b08669fce281ca4bb360c64e7558bd0143fda3

commit 33b08669fce281ca4bb360c64e7558bd0143fda3
Author: Jiaquan He <hejq@google.com>
Date: Fri Jul 21 17:43:39 2017

Ignore voice queries for Play Store app search.

Voice queries just simply close the launcher. We don't need
voice queries for Play Store app search.

Bug= 736027 

Change-Id: Ic34c45ad105c20598b6fc4bcb345883f55ccc012
Reviewed-on: https://chromium-review.googlesource.com/579958
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#488697}
[modify] https://crrev.com/33b08669fce281ca4bb360c64e7558bd0143fda3/chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider.cc

Comment 3 by hejq@chromium.org, Jul 21 2017

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 29 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fd9776787fa1b8313183f7daedea059ee17dc34

commit 6fd9776787fa1b8313183f7daedea059ee17dc34
Author: Maajid <maajid@chromium.org>
Date: Sat Jul 29 00:32:57 2017

Ignore voice queries for Play Store app search.

Voice queries just simply close the launcher. We don't need
voice queries for Play Store app search.

Bug= 736027 

TBR=hejq@google.com

(cherry picked from commit 33b08669fce281ca4bb360c64e7558bd0143fda3)

Change-Id: Ic34c45ad105c20598b6fc4bcb345883f55ccc012
Reviewed-on: https://chromium-review.googlesource.com/579958
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#488697}
Bug: 
Reviewed-on: https://chromium-review.googlesource.com/592388
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#126}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/6fd9776787fa1b8313183f7daedea059ee17dc34/chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider.cc

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment