New issue
Advanced search Search tips

Issue 736024 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 736624
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Bad-cast to gl::Surface from egl::PBufferSurface;es2::Context::makeCurrent;egl::MakeCurrent

Project Member Reported by ClusterFuzz, Jun 22 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6158811584004096

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x06dde8372b60
Crash State:
  Bad-cast to gl::Surface from egl::PBufferSurface
  es2::Context::makeCurrent
  egl::MakeCurrent
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=481503:481513

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6158811584004096


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by mmoroz@chromium.org, Jun 22 2017

Components: Internals>GPU>SwiftShader
Labels: Pri-1
Owner: capn@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by ClusterFuzz, Jun 23 2017

ClusterFuzz has detected this issue as fixed in range 481513:481531.

Detailed report: https://clusterfuzz.com/testcase?key=6158811584004096

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x06dde8372b60
Crash State:
  Bad-cast to gl::Surface from egl::PBufferSurface
  es2::Context::makeCurrent
  egl::MakeCurrent
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=481503:481513
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=481513:481531

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6158811584004096


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, Jun 23 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6158811584004096 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 23 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify

Comment 6 by capn@chromium.org, Jun 23 2017

It got "fixed" by a DEPS roll revert, which was done for a different reason (Issue 735920). The change that caused this will land again, but it's a benign issue because UBSan doesn't seem to know that egl::PBufferSurface is derived from gl::Surface because it was created in a different library. The compiler knows it's a safe upcast though, so I think this is essentially a UBSan issue.

Comment 7 by capn@chromium.org, Jun 26 2017

Mergedinto: 736624
Status: Duplicate (was: Verified)
Project Member

Comment 8 by sheriffbot@chromium.org, Oct 3 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment