New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735999 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 740799
issue 748620

Blocking:
issue 725977



Sign in to add a comment

Tablet WM: Swiping on the shelf to open the new launcher

Project Member Reported by minch@chromium.org, Jun 22 2017

Issue description

Swiping up on the shelf area should open the app list.
1.Only tablet.
2.Only bottom shelf.
3.Except system tray area, which swiping should show the system tray bubble.

If the app list is open. Swiping on the shelf should keep the app list opened. Tap the shelf or open any other views (e.g, context menu, system tray bubble.) should close the app list.
 

Comment 1 by minch@chromium.org, Jun 29 2017

Description: Show this description

Comment 2 by minch@chromium.org, Jul 6 2017

Description: Show this description

Comment 3 by minch@chromium.org, Jul 11 2017

Description: Show this description

Comment 4 by minch@chromium.org, Jul 11 2017

Description: Show this description

Comment 5 by minch@chromium.org, Jul 11 2017

Blockedon: 740799
Cc: abodenha@chromium.org omrilio@chromium.org
Has this been through UX review? Can we link any design discussion for this here?

Comment 7 by minch@chromium.org, Jul 11 2017

Cc: newcomer@chromium.org warx@chromium.org
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZY5BZ8F2qhKy/files/MCGlADLXfEphY0VvrzTnhxdQwMSJbxAVNpw

This includes the prototype of the swiping up on the shelf, but it is only for laptop. What I did currently is for tablet.
The first CL is to show the whole app list first. Will add the animation in the following cls (e.g, fade in / out the searchbox at the beginning).
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d646ae0a014564fd9fb4e879e70837ea715a64e9

commit d646ae0a014564fd9fb4e879e70837ea715a64e9
Author: MinChen <minch@chromium.org>
Date: Fri Jul 21 23:07:17 2017

Swiping up on shelf to show the app list.

If the app list is not opened and shelf is visible, swipe up on the shelf
should show the app list.
If the app list is opened, swipe up on the shelf should keep the app list
opened. Tap anywhere else of shelf should close the app list.

This is the basic one currently. Will add some simple animations followed.
(e.g, change the opacity of the searchbox and apps row by row according
to the dragging amount)

Bug:  735999 ,742461
Change-Id: I5eb8b6d4d006a50720050b34168849e9d57370f2
Reviewed-on: https://chromium-review.googlesource.com/562739
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488781}
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ash/shelf/shelf_view.cc
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ash/shell.cc
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ash/shell.h
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ash/shell/example_app_list_presenter.cc
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ash/shell/example_app_list_presenter.h
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ash/system/tray_drag_controller.cc
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/chrome/browser/ui/ash/app_list/app_list_presenter_service.cc
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/chrome/browser/ui/ash/app_list/app_list_presenter_service.h
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ui/app_list/presenter/app_list.cc
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ui/app_list/presenter/app_list.h
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ui/app_list/presenter/app_list_presenter.mojom
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ui/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ui/app_list/presenter/app_list_presenter_impl.h
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ui/app_list/presenter/test/test_app_list_presenter.cc
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ui/app_list/presenter/test/test_app_list_presenter.h
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/d646ae0a014564fd9fb4e879e70837ea715a64e9/ui/app_list/views/app_list_view.h

Comment 9 by minch@chromium.org, Jul 25 2017

Blockedon: 748620

Comment 10 by minch@chromium.org, Jul 25 2017

Blocking: 725977
Re comment #6 - yes it has.
Designs are in comment #7
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 29 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe

commit dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe
Author: Maajid <maajid@chromium.org>
Date: Sat Jul 29 00:59:54 2017

Swiping up on shelf to show the app list.

If the app list is not opened and shelf is visible, swipe up on the shelf
should show the app list.
If the app list is opened, swipe up on the shelf should keep the app list
opened. Tap anywhere else of shelf should close the app list.

This is the basic one currently. Will add some simple animations followed.
(e.g, change the opacity of the searchbox and apps row by row according
to the dragging amount)

TBR=minch@chromium.org

(cherry picked from commit d646ae0a014564fd9fb4e879e70837ea715a64e9)

Bug:  735999 ,742461
Change-Id: I5eb8b6d4d006a50720050b34168849e9d57370f2
Reviewed-on: https://chromium-review.googlesource.com/562739
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488781}
Reviewed-on: https://chromium-review.googlesource.com/592692
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#129}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ash/shelf/shelf_view.cc
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ash/shell.cc
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ash/shell.h
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ash/shell/example_app_list_presenter.cc
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ash/shell/example_app_list_presenter.h
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ash/system/tray_drag_controller.cc
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/chrome/browser/ui/ash/app_list/app_list_presenter_service.cc
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/chrome/browser/ui/ash/app_list/app_list_presenter_service.h
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ui/app_list/presenter/app_list.cc
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ui/app_list/presenter/app_list.h
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ui/app_list/presenter/app_list_presenter.mojom
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ui/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ui/app_list/presenter/app_list_presenter_impl.h
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ui/app_list/presenter/test/test_app_list_presenter.cc
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ui/app_list/presenter/test/test_app_list_presenter.h
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/dc2e10a3aeeb15325a604b3e8888ed149fb9a1fe/ui/app_list/views/app_list_view.h

Comment 13 by minch@chromium.org, Aug 27 2017

Status: Fixed (was: Assigned)
Labels: M-61

Sign in to add a comment