New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735986 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocked on:
issue 730126

Blocking:
issue 737197



Sign in to add a comment

ANGLE D3D11 nullptr dereference causing crash in release version of Chrome

Project Member Reported by jmad...@chromium.org, Jun 22 2017

Issue description

Currently affecting release branch 3112. This is a result of an incorrect merge conflict resolution in  issue 730126 .

 
Blockedon: 730126
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2017

Labels: merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/3e6a61fecba96d06ac24e9bc0e4a030f2bb3cc1d

commit 3e6a61fecba96d06ac24e9bc0e4a030f2bb3cc1d
Author: Jamie Madill <jmadill@chromium.org>
Date: Thu Jun 22 16:43:09 2017

D3D11: Fix nullptr dereference from bad merge.

f1ca5288af was a cherry-pick that was merged incorrectly after
some conflicts. This was causing a very serious crasher in Chrome.

BUG= chromium:730126 
BUG= chromium:735986 

Change-Id: I82a48c25d604e1088800cb870297ccfef5915fc5
Reviewed-on: https://chromium-review.googlesource.com/544541
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/3e6a61fecba96d06ac24e9bc0e4a030f2bb3cc1d/src/libANGLE/renderer/d3d/d3d11/Clear11.cpp

Issue 736010 has been merged into this issue.
Status: Fixed (was: Assigned)
Cc: geoffl...@chromium.org sugoi@chromium.org zmo@chromium.org capn@chromium.org jmad...@chromium.org
 Issue 736622  has been merged into this issue.
 Issue 736863  has been merged into this issue.
 Issue 736666  has been merged into this issue.
What 3112 branch version will include the fix?
I don't know how release branch versions work.. maybe someone with more experience with the branching and releasing can answer. The buildspec files set up the branches to pick up the latest version of ANGLE from the chromium/3112 branch, which has the fix applied, and the fix was landed Thursday as seen in comment #2.
Thanks. I've manually applied your fix to 60.0.3112.40 for now and that resolved the problem for me.
Blocking: 737197

Sign in to add a comment