New issue
Advanced search Search tips

Issue 735960 link

Starred by 1 user
Status: Verified
Owner:
cjgrant@chromium.org
Closed: Jun 2017
Cc:
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 731919



Sign in to add a comment

Make VR properly render RTL URLs instead of bailing

Project Member Reported by cjgrant@chromium.org, Jun 22 2017 
At current ToT, VR bails out if a URL contains strong RTL characters.  The Views implementation appears to handle RTL by enforcing LTR rendering of characters on the URL.  See here:

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/omnibox/omnibox_view_views.cc?l=600

Rather than bailing out, we should simply set the same directionality setting for VR's version.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1f64db1a25c84c6583e9ac7dc2e035a6b8ddfec

commit c1f64db1a25c84c6583e9ac7dc2e035a6b8ddfec
Author: cjgrant <cjgrant@chromium.org>
Date: Fri Jun 23 22:45:00 2017

VR: Enforce LTR directionality on rendered URL text.

Do as the Views-based omnibox does, and enforce LTR on URL text.  This
ensures that malicious URLs can't visually spoof a hostname.  Also, add a unit test to ensure that the LTR directionality holds up against such a URL.

TBR=estark@chromium.org
BUG= 735960 

Review-Url: https://codereview.chromium.org/2945173006
Cr-Commit-Position: refs/heads/master@{#482054}

[modify] https://crrev.com/c1f64db1a25c84c6583e9ac7dc2e035a6b8ddfec/chrome/browser/android/vr_shell/textures/url_bar_texture.cc
[modify] https://crrev.com/c1f64db1a25c84c6583e9ac7dc2e035a6b8ddfec/chrome/browser/android/vr_shell/textures/url_bar_texture.h
[modify] https://crrev.com/c1f64db1a25c84c6583e9ac7dc2e035a6b8ddfec/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc

Comment 2 by cjgrant@chromium.org, Jun 23 2017

Status: Fixed (was: Assigned)

Comment 4 by dbbrooks@chromium.org, Jul 27 2017

Status: Verified (was: Fixed)

Comment 5 by vollick@chromium.org, Aug 9 2017

Blocking: 731919
►

Sign in to add a comment