New issue
Advanced search Search tips

Issue 735951 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 694255



Sign in to add a comment

Add a perf bot that runs V8 with concurrent marking enabled

Project Member Reported by u...@chromium.org, Jun 22 2017

Issue description

A perf bot would be very useful to track perf optimization with concurrent marking.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/55161bda08bfc57e193fcf8df42bc54c038db45b

commit 55161bda08bfc57e193fcf8df42bc54c038db45b
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Jun 23 12:29:38 2017

V8: Add concurrent-marking builder

On infrastructure-side the new builder is the same as linux64, but the
MB config will switch on concurrent marking. Therefore the builds
will be stored in a distinguished GS path.

The bot triggers the internal proxy for perf tests.

Bug:  735951 
Change-Id: Ice01e9b16793b6123739e22d1cc90a26a9331105
Reviewed-on: https://chromium-review.googlesource.com/545002
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/55161bda08bfc57e193fcf8df42bc54c038db45b/scripts/slave/recipe_modules/v8/builders.py
[modify] https://crrev.com/55161bda08bfc57e193fcf8df42bc54c038db45b/scripts/slave/recipe_modules/v8/api.py
[add] https://crrev.com/55161bda08bfc57e193fcf8df42bc54c038db45b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___concurrent_marking___builder.json
[modify] https://crrev.com/55161bda08bfc57e193fcf8df42bc54c038db45b/masters/master.client.v8/slaves.cfg
[modify] https://crrev.com/55161bda08bfc57e193fcf8df42bc54c038db45b/masters/master.client.v8/master.cfg

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/882221997850fc85868c22b2e050e6a34c41049f

commit 882221997850fc85868c22b2e050e6a34c41049f
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Jun 23 13:00:40 2017

[build] Add concurrent-marking builder

NOTRY=true
NOTREECHECKS=true
TBR=ulan@chromium.org

Bug:  chromium:735951 
Change-Id: I8b54ba272d353b1fb499fcfccef1f49b9c47a137
Reviewed-on: https://chromium-review.googlesource.com/544828
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46172}
[modify] https://crrev.com/882221997850fc85868c22b2e050e6a34c41049f/infra/mb/mb_config.pyl

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/2cae36fd953a558d332cfa51678a4be341fe5e96

commit 2cae36fd953a558d332cfa51678a4be341fe5e96
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Jun 23 14:17:32 2017

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 23 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 23 2017

Status: Fixed (was: Started)
This is done.

Data is uploaded e.g. here:
https://chromeperf.appspot.com/report?sid=6b0ea958d2dcc9bf6fc271a31013efe229518e26a44db1fdd49998cf30d33668

We test octane on the CM bot. Currently there's a crash, so not all data is uploaded (Typescript is missing):
https://uberchromegw.corp.google.com/i/internal.client.v8/builders/v8_linux64_haswell_cm_perf/builds/4

You can also use the trybot v8_linux64_haswell_cm_perf_try with all benchmarks.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5d39f7c13b1922899820572a64770ee8b7635a87

commit 5d39f7c13b1922899820572a64770ee8b7635a87
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Jun 26 07:33:48 2017

[test] Add flag for concurrent-marking trybot to try_perf

NOTRY=true
TBR=ulan@chromium.org

Bug:  chromium:735951 
Change-Id: Ic5cf6692988ede915aabdc1c44eea52b42bf7f45
Reviewed-on: https://chromium-review.googlesource.com/547426
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46199}
[modify] https://crrev.com/5d39f7c13b1922899820572a64770ee8b7635a87/tools/try_perf.py

Comment 9 by u...@chromium.org, Jun 27 2017

Thanks a lot, Michael!

Sign in to add a comment