New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 735939 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
█ benjamin...@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

urllib3 doesn't correctly catch OpenSSL.SSL.SysCallError

Project Member Reported by mar...@chromium.org, Jun 22 2017 
Maybe the fix is to update urllib3, need to look up upstream first. If not, maybe upstream a fix. The fix in _send_until_done() would look like :
  except OpenSSL.SSL.SysCallError as e:
    raise SocketError(e)

This catch the exception correctly:
https://github.com/luci/luci-py/blob/master/client/third_party/requests/packages/urllib3/contrib/pyopenssl.py#L181

but the exception was thrown at:
https://github.com/luci/luci-py/blob/master/client/third_party/requests/packages/urllib3/contrib/pyopenssl.py#L207

Ref:
https://chromium-swarm.appspot.com/task?id=36e599da2b358510
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 22 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by tandrii@chromium.org, Jun 26 2018

Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
►

Sign in to add a comment