Issue metadata
Sign in to add a comment
|
10.3% regression in blink_perf.paint at 480465:480561 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 22 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8976083351628184208
,
Jun 22 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8976083344690744160
,
Jun 23 2017
=== Auto-CCing suspected CL author eae@chromium.org === Hi eae@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : eae Commit : 3a9ec9418cd17a5ae1d8db43d5eb7369ad0358ca Date : Mon Jun 19 17:30:42 2017 Subject: Break LayoutObject dependency for ImageQualityController Bisect Details Configuration: android_nexus5_perf_bisect Benchmark : blink_perf.paint Metric : paint-offset-changes/paint-offset-changes Change : 11.10% | 2244.8721 -> 2493.95541667 Revision Result N chromium@480464 2244.87 +- 13.5774 5 good chromium@480477 2218.16 +- 22.9957 6 good chromium@480480 2234.31 +- 28.532 6 good chromium@480482 2242.23 +- 22.4609 6 good chromium@480483 2613.04 +- 48.3175 6 bad <-- chromium@480489 2590.0 +- 96.902 6 bad chromium@480513 2530.23 +- 20.488 6 bad chromium@480561 2493.96 +- 50.333 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.paint Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8976083351628184208 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=4517380060872704 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 23 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : eae Commit : 3a9ec9418cd17a5ae1d8db43d5eb7369ad0358ca Date : Mon Jun 19 17:30:42 2017 Subject: Break LayoutObject dependency for ImageQualityController Bisect Details Configuration: android_nexus5_perf_bisect Benchmark : blink_perf.paint Metric : paint-offset-changes/paint-offset-changes Change : 9.76% | 2257.8425 -> 2478.13975 Revision Result N chromium@480464 2257.84 +- 21.1395 6 good chromium@480477 2226.84 +- 32.8605 6 good chromium@480480 2225.49 +- 19.2871 6 good chromium@480482 2223.26 +- 21.2051 6 good chromium@480483 2609.2 +- 33.0076 6 bad <-- chromium@480489 2573.38 +- 29.8544 6 bad chromium@480513 2526.67 +- 36.2259 6 bad chromium@480561 2478.14 +- 44.1044 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.paint Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8976083344690744160 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5623698272288768 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jul 27 2017
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md We're looking for one of the following: 1. Justification via explanation 2. Plan to revert or fix 3. Angry rage throwing of equipment at my head Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it. Note: This was a bulk edit message and not very personal.
,
Aug 3 2017
ImageQualityController has since been disabled by removed. The code in question is no longer being executed. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by kraynov@chromium.org
, Jun 22 2017