New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735933 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Extend OverlayCandidate support for more quad types.

Project Member Reported by sohan.jy...@huawei.com, Jun 22 2017

Issue description

Currently OverlayCandidate::FromDrawQuad supports only TextureQuad and StreamVideoQuad.
We should extend support for other quad types to make them overlayable.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f00ffcc2e0ac0ca70a5f84aa52dd9e9e94c25ee

commit 3f00ffcc2e0ac0ca70a5f84aa52dd9e9e94c25ee
Author: sohan <sohan.jyoti@huawei.com>
Date: Fri Jul 14 22:28:08 2017

cc: Support TileQuad as OverlayCandidate.

This adds TileDrawQuad as possible overlay candidate by
setting up the candidate overlay with right properties from
the draw quad. Also adds debug color borders for them.

BUG= 735933 

Change-Id: I5646c66e304aafb470e76eaf31a990b7e3ddc155
Reviewed-on: https://chromium-review.googlesource.com/571784
Reviewed-by: Sohan Jyoti Ghosh <sohan.jyoti@huawei.com>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Sohan Jyoti Ghosh <sohan.jyoti@huawei.com>
Cr-Commit-Position: refs/heads/master@{#486911}
[modify] https://crrev.com/3f00ffcc2e0ac0ca70a5f84aa52dd9e9e94c25ee/cc/base/switches.cc
[modify] https://crrev.com/3f00ffcc2e0ac0ca70a5f84aa52dd9e9e94c25ee/cc/base/switches.h
[modify] https://crrev.com/3f00ffcc2e0ac0ca70a5f84aa52dd9e9e94c25ee/cc/output/gl_renderer.cc
[modify] https://crrev.com/3f00ffcc2e0ac0ca70a5f84aa52dd9e9e94c25ee/cc/output/gl_renderer.h
[modify] https://crrev.com/3f00ffcc2e0ac0ca70a5f84aa52dd9e9e94c25ee/cc/output/overlay_candidate.cc
[modify] https://crrev.com/3f00ffcc2e0ac0ca70a5f84aa52dd9e9e94c25ee/cc/output/overlay_candidate.h
[modify] https://crrev.com/3f00ffcc2e0ac0ca70a5f84aa52dd9e9e94c25ee/cc/output/renderer_settings.h
[modify] https://crrev.com/3f00ffcc2e0ac0ca70a5f84aa52dd9e9e94c25ee/chrome/browser/about_flags.cc
[modify] https://crrev.com/3f00ffcc2e0ac0ca70a5f84aa52dd9e9e94c25ee/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/3f00ffcc2e0ac0ca70a5f84aa52dd9e9e94c25ee/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/3f00ffcc2e0ac0ca70a5f84aa52dd9e9e94c25ee/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3f00ffcc2e0ac0ca70a5f84aa52dd9e9e94c25ee/ui/compositor/compositor_util.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment