generate_build_files fails on Mac |
||||||||
Issue descriptionFirst build: https://build.chromium.org/p/chromium/builders/Mac/builds/29199 """ to /b/c/b/mac/src/out/Release/args.gn. /b/c/b/mac/src/buildtools/mac/gn gen //out/Release --check -> returned 1 ERROR at //third_party/angle/BUILD.gn:587:1: Duplicate output file. shared_library("libEGL") { ^------------------------- Two or more targets generate the same output: libEGL.dylib.unstripped This is can often be fixed by changing one of the target names, or by setting an output_name on one of them. Collisions: //third_party/angle:libEGL //third_party/swiftshader/src/OpenGL/libEGL:swiftshader_libEGL See //third_party/swiftshader/src/OpenGL/libEGL/BUILD.gn:43:1: Collision. shared_library("swiftshader_libEGL") { ^------------------------------------- GN gen failed: 1 step returned non-zero exit code: 1 Caused by the most recent SwiftShader roll in https://codereview.chromium.org/2947343002/.
,
Jun 22 2017
WIP https://chromium-review.googlesource.com/544758 I suspect dsym_output_dir might need the same fix.
,
Jun 22 2017
,
Jun 23 2017
The following revision refers to this bug: https://swiftshader.googlesource.com/SwiftShader.git/+/9282c6d71f730ff604469951a1f6615baa57c056 commit 9282c6d71f730ff604469951a1f6615baa57c056 Author: Nicolas Capens <capn@google.com> Date: Fri Jun 23 20:15:05 2017 Rename libraries on Mac OS to prevent conflicts. ANGLE and SwiftShader produce libraries with the same name, which causes conflicts for Chrome on Mac OS when creating unstripped libraries and dSYM debug information. Renaming them temporarily works around the build tools issue. Bug chromium:735920 Change-Id: Icb4f484970ec75b8c5e7e784ce37e05ee4fbc7db Reviewed-on: https://swiftshader-review.googlesource.com/10288 Reviewed-by: Nicolas Capens <capn@google.com> Tested-by: Nicolas Capens <capn@google.com> [modify] https://crrev.com/9282c6d71f730ff604469951a1f6615baa57c056/src/OpenGL/libEGL/BUILD.gn [modify] https://crrev.com/9282c6d71f730ff604469951a1f6615baa57c056/src/OpenGL/libEGL/libEGL.hpp [modify] https://crrev.com/9282c6d71f730ff604469951a1f6615baa57c056/src/OpenGL/libGLESv2/BUILD.gn [modify] https://crrev.com/9282c6d71f730ff604469951a1f6615baa57c056/src/OpenGL/libGLESv2/libGLESv2.hpp [modify] https://crrev.com/9282c6d71f730ff604469951a1f6615baa57c056/tests/unittests/BUILD.gn
,
Jun 23 2017
As discussed at https://chromium-review.googlesource.com/544758 a proper fix will require passing a debug_output_dir from the target to the toolchain. We want this because libEGL and libGLESv2 are standard names for OpenGL ES graphics drivers and they need to be able to load each other, even when another directory might contain a different driver implementation (in this case ANGLE). There shouldn't be Chrome specific (naming) demands on these libraries.
,
Jun 23 2017
,
Jun 27 2017
,
Jul 6 2017
FYI an example of adding a new GN variable: https://codereview.chromium.org/1887533003
,
Jul 9
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 9
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 22 2017