New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 735918 link

Starred by 1 user
Status: WontFix
Owner:
█ ananta@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
yhirano@chromium.org
csharrison@chromium.org
█ rdsmith@chromium.org
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Incorrect usage of ThreadChecker in content/browser/loader/netlog_observer.cc

Project Member Reported by fdoray@chromium.org, Jun 22 2017 
ThreadChecker::CalledOnValidThread() always returns true in non-DCHECK builds https://chromium.googlesource.com/chromium/src/+/d9a4e3e3f860fb848ce36deea29f0d685c6d81c6/base/threading/thread_checker.h#82 It is incorrect to use it in an if statement https://chromium.googlesource.com/chromium/src/+/d9a4e3e3f860fb848ce36deea29f0d685c6d81c6/content/browser/loader/netlog_observer.cc#50

To determine whether something runs on the IO thread, use BrowserThread::CurrentlyOn(BrowserThread::IO).

Comment 1 by fdoray@chromium.org, Jun 22 2017 

To verify that something runs on a specific thread which isn't necessarily the IO thread, use ThreadCheckerImpl instead of ThreadChecker.

Comment 2 by mmenke@chromium.org, Jun 22 2017

Components: Platform>DevTools

Comment 3 by csharrison@chromium.org, Jun 22 2017

Cc: csharrison@chromium.org
Owner: ananta@chromium.org
To ananta who added this code, explicitly to remove browser thread IDs from it :)

Comment 4 by dgozman@chromium.org, Sep 21 2017

Status: WontFix (was: Assigned)
NetLogObserver is gone for a while.
►

Sign in to add a comment