Regression : Flickering of 'Remove this person' overlay is seen after clicking on 'Remove this person' button.
Reported by
rp...@etouch.net,
Jun 22 2017
|
||||||||||
Issue descriptionVersion: 61.0.3138.0 d2d3a3975e9c7f3c5c62ef0ecad2683332894600-refs/heads/master@{#481386} OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3) What steps will reproduce the problem? 1. Freshly launch chrome and click on avatar icon on top RHS of browser window and then click on 'Manage people' 2. Now click on iron icon of person profile and then click on 'Remove this person' button and observe Actual: Flickering of 'Remove this person' overlay is seen after clicking on 'Remove this person' button Expected: Flickering of 'Remove this person' overlay should not be seen after clicking on 'Remove this person' button This is regression issue, broken in ‘M 61’ and will soon update other info : Good build:61.0.3130.0 Bad build: 61.0.3131.0
,
Jun 22 2017
Could you explain how this this bisect was created? My refactoring CL 37ee286af06538 has practically no functional change, and I don't think it could affect the profile management UI in the way you're describing using these videos.
,
Jun 22 2017
,
Jun 23 2017
As per comment #2&3 Re-bisected using the per-revision bisect providing the bisect results, Good build:61.0.3130.0(Revision:479232). Bad build:61.0.3131.0(Revision:479564). You are probably looking for a change made after 479335 (known good), but no later than 479336 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/93d013d8cd6a86cc366aa46ccf2f1f51361e159b..17645964f33b591deea14589845132be05e8ad9f From the CL above, assigning the issue to the concern owner @dullweber: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Reviewed-on: https://codereview.chromium.org/2915053002
,
Jun 23 2017
Thanks for reporting this, I will look into it. I changed how the values are loaded and it seems weird that you are getting the "This will permanently delete your browsing data" text instead of the counters from expected_video.
,
Jun 26 2017
,
Jun 26 2017
The "This will permanently delete your browsing data" text will only be shown if there are zero items to delete. This can happen with a fresh profile or after clearing browsing data. As soon as there is at least one item, the counters will be shown and there is no flickering. We could easily solve this by showing the counters for all zero values as well. Alternatively we would have to delay the dialog for a short moment or until at least one non-zero counter has finished. max, martin: what do you think about this?
,
Jun 26 2017
I created a proposal, for how this could be fixed: http://docs/document/d/1ts465ST49BXSft8lsaQ2CxzJy_-4aa-vq23KOUTVvyI/edit#heading=h.1iob68izxmk8
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/029879a344b8766661b7ce935a6431e5b3922b95 commit 029879a344b8766661b7ce935a6431e5b3922b95 Author: dullweber <dullweber@chromium.org> Date: Wed Jun 28 16:01:44 2017 Don't hide profile statistics counters with zero results Currently the profile statistics counters are hidden if all of them returned zero. This leads to an unstable, flickering UI. This Cl changes them to always be visible to avoid this issue. BUG= 735873 Review-Url: https://codereview.chromium.org/2956873002 Cr-Commit-Position: refs/heads/master@{#483010} [modify] https://crrev.com/029879a344b8766661b7ce935a6431e5b3922b95/ui/login/account_picker/md_user_pod_row.css [modify] https://crrev.com/029879a344b8766661b7ce935a6431e5b3922b95/ui/login/account_picker/md_user_pod_row.js [modify] https://crrev.com/029879a344b8766661b7ce935a6431e5b3922b95/ui/login/account_picker/user_pod_row.css [modify] https://crrev.com/029879a344b8766661b7ce935a6431e5b3922b95/ui/login/account_picker/user_pod_row.js
,
Jun 30 2017
The flickering is fixed by always showing the counters. I will land another CL that removes the total item count as well but that can reference the eng tracking bug.
,
Jul 11 2017
Correction: Above issue is fixed on latest Dev version 61.0.3153.0
,
Jul 11 2017
Correction: Above issue is fixed on latest Dev version 61.0.3153.4 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by rbasuvula@chromium.org
, Jun 22 2017Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: drott@chromium.org
Status: Assigned (was: Unconfirmed)