New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735873 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 716267



Sign in to add a comment

Regression : Flickering of 'Remove this person' overlay is seen after clicking on 'Remove this person' button.

Reported by rp...@etouch.net, Jun 22 2017

Issue description

Version: 61.0.3138.0 d2d3a3975e9c7f3c5c62ef0ecad2683332894600-refs/heads/master@{#481386}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3)

What steps will reproduce the problem?
1. Freshly launch chrome and click on avatar icon on top RHS of browser window and then click on 'Manage people'
2. Now click on iron icon of person profile and then click on 'Remove this person' button and observe

Actual: Flickering of 'Remove this person' overlay is seen after clicking on 'Remove this person' button
Expected: Flickering of 'Remove this person' overlay should not be seen after clicking on 'Remove this person' button

This is regression issue, broken in ‘M 61’ and will soon update other info :
Good build:61.0.3130.0
Bad build: 61.0.3131.0
 
Actual_video.mov
1.7 MB Download
Expected_video.mp4
263 KB View Download
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: drott@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3130.0(Revision:479232).
Bad build:61.0.3131.0(Revision:479564).

You are probably looking for a change made after 479352 (known good), but no later than 479353 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/0923b5913aa087a0ffd8695a49aae2931e0e5c56..37ee286af065385f62db869e5579de96da1634c0

From the CL above, assigning the issue to the concern owner

@drott: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Reviewed-on:https://chromium-review.googlesource.com/535535
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3138.0
Adding Release Block-Stable for this issue.Please remove if not the case.

Comment 2 by drott@chromium.org, Jun 22 2017

Cc: drott@chromium.org
Owner: ----
Status: Available (was: Assigned)
Could you explain how this this bisect was created? My refactoring CL 37ee286af06538 has practically no functional change, and I don't think it could affect the profile management UI in the way you're describing using these videos.
Labels: Needs-Bisect
Labels: -Needs-Bisect
Owner: dullweber@chromium.org
Status: Assigned (was: Available)
As per comment #2&3 Re-bisected using the per-revision bisect providing the bisect results,
Good build:61.0.3130.0(Revision:479232).
Bad build:61.0.3131.0(Revision:479564).

You are probably looking for a change made after 479335 (known good), but no later than 479336 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/93d013d8cd6a86cc366aa46ccf2f1f51361e159b..17645964f33b591deea14589845132be05e8ad9f

From the CL above, assigning the issue to the concern owner

@dullweber: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Reviewed-on: https://codereview.chromium.org/2915053002

Blocking: 716267
Thanks for reporting this, I will look into it. 
I changed how the values are loaded and it seems weird that you are getting the "This will permanently delete your browsing data" text instead of the counters from expected_video.

Comment 6 by drott@chromium.org, Jun 26 2017

Cc: -drott@chromium.org
Cc: msramek@chromium.org maxwalker@chromium.org
The "This will permanently delete your browsing data" text will only be shown if there are zero items to delete. This can happen with a fresh profile or after clearing browsing data. 
As soon as there is at least one item, the counters will be shown and there is no flickering. We could easily solve this by showing the counters for all zero values as well. 

Alternatively we would have to delay the dialog for a short moment or until at least one non-zero counter has finished.

max, martin: what do you think about this?
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/029879a344b8766661b7ce935a6431e5b3922b95

commit 029879a344b8766661b7ce935a6431e5b3922b95
Author: dullweber <dullweber@chromium.org>
Date: Wed Jun 28 16:01:44 2017

Don't hide profile statistics counters with zero results

Currently the profile statistics counters are hidden if all of them
returned zero. This leads to an unstable, flickering UI. This Cl
changes them to always be visible to avoid this issue.

BUG= 735873 

Review-Url: https://codereview.chromium.org/2956873002
Cr-Commit-Position: refs/heads/master@{#483010}

[modify] https://crrev.com/029879a344b8766661b7ce935a6431e5b3922b95/ui/login/account_picker/md_user_pod_row.css
[modify] https://crrev.com/029879a344b8766661b7ce935a6431e5b3922b95/ui/login/account_picker/md_user_pod_row.js
[modify] https://crrev.com/029879a344b8766661b7ce935a6431e5b3922b95/ui/login/account_picker/user_pod_row.css
[modify] https://crrev.com/029879a344b8766661b7ce935a6431e5b3922b95/ui/login/account_picker/user_pod_row.js

Status: Fixed (was: Assigned)
The flickering is fixed by always showing the counters. I will land another CL that removes the total item count as well but that can reference the eng tracking bug.

Comment 11 Deleted

Comment 12 by rp...@etouch.net, Jul 11 2017

Labels: -TE-Verified-61.0.3154.0 TE-Verified-61.0.3153.0
Correction: Above issue is fixed on latest Dev version 61.0.3153.0

Comment 13 by rp...@etouch.net, Jul 11 2017

Labels: TE-Verified-61.0.3153.4
Correction: Above issue is fixed on latest Dev version 61.0.3153.4

Sign in to add a comment