Password manager search is case sensitive
Reported by
mr.ber...@gmail.com,
Jun 22 2017
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.109 Safari/537.36 Steps to reproduce the problem: 1. Go to chrome://settings/passwords (Material Design) 2. Search for Google What is the expected behavior? You should find something, I guess. What went wrong? You probably don't. Searching "Google" does not find "google". Did this work before? N/A Chrome version: 59.0.3071.109 Channel: stable OS Version: 10.0 Flash Version: Shockwave Flash 26.0 r0
,
Jun 23 2017
Unable to reproduce this issue on Windows-10 using chrome latest stable #59.0.3071.109. By typing google in the search password field observed the google related pages gets filtered and shows the result under saved passwords. Reporter@ Could you please recheck this issue by creating a new profile under chrome://settings with no apps or extensions in your browser. If issue still persists please provide a screen-cast for better understanding. Thanks!
,
Jun 23 2017
Please type "Google" in the search field, not "google", to reproduce the issue.
,
Jun 23 2017
Thank you for providing more feedback. Adding requester "brajkumar@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 23 2017
As per step-3 able to reproduce this issue on Windows-10, Ubuntu 14.04 and Mac OS 10.12.5 using chrome latest stable #59.0.3071.109. This issue is observed on chrome older version of M55-55.0.2841.0 as well. Considering this is a non-regression issue and marking it as untriaged. Thanks!
,
Jun 27 2017
Interesting. While I can also reproduce, I so far don't see where the error is in the code. Looking at setSavedPasswordsList_ in chrome/browser/resources/options/password_manager.js, the comparison is done after applying toLowerCase to both the search query and the credential fields. I cannot investigate now, so marking this as Available.
,
Jun 27 2017
,
Aug 3 2017
I have a CL up for this here: https://chromium-review.googlesource.com/c/600855
,
Aug 3 2017
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/879ed39c816c2f06b234c90a53f9b9f08d822852 commit 879ed39c816c2f06b234c90a53f9b9f08d822852 Author: Lenny Khazan <lenny.khazan@gmail.com> Date: Fri Aug 04 22:44:38 2017 Make password filtering case insensitive The password filter in chrome://settings/passwords is now case insensitive. Bug: 735867 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I24e5a6c0b4f07daf4e493be2c4be969c5146e9fb Reviewed-on: https://chromium-review.googlesource.com/600855 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#492158} [modify] https://crrev.com/879ed39c816c2f06b234c90a53f9b9f08d822852/AUTHORS [modify] https://crrev.com/879ed39c816c2f06b234c90a53f9b9f08d822852/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js [modify] https://crrev.com/879ed39c816c2f06b234c90a53f9b9f08d822852/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
,
Aug 8 2017
Assuming this is fixed now. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ligim...@chromium.org
, Jun 22 2017Labels: Needs-Triage-M59