New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735867 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 714618



Sign in to add a comment

Password manager search is case sensitive

Reported by mr.ber...@gmail.com, Jun 22 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.109 Safari/537.36

Steps to reproduce the problem:
1. Go to chrome://settings/passwords (Material Design)
2. Search for Google

What is the expected behavior?
You should find something, I guess.

What went wrong?
You probably don't. Searching "Google" does not find "google".

Did this work before? N/A 

Chrome version: 59.0.3071.109  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 26.0 r0
 
Components: -UI UI>Browser>Passwords
Labels: Needs-Triage-M59
Cc: brajkumar@chromium.org
Labels: Needs-Feedback
Unable to reproduce this issue on Windows-10 using chrome latest stable #59.0.3071.109. By typing google in the search password field observed the google related pages gets filtered and shows the result under saved passwords.

Reporter@ Could you please recheck this issue by creating a new profile under chrome://settings with no apps or extensions in your browser. If issue still persists please provide a screen-cast for better understanding.

Thanks!

Comment 3 by mr.ber...@gmail.com, Jun 23 2017

Please type "Google" in the search field, not "google", to reproduce the issue.
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 23 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "brajkumar@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: M-61 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
As per step-3 able to reproduce this issue on Windows-10, Ubuntu 14.04 and Mac OS 10.12.5 using chrome latest stable #59.0.3071.109.

This issue is observed on chrome older version of M55-55.0.2841.0 as well. Considering this is a non-regression issue and marking it as untriaged.

Thanks!

Comment 6 by vabr@chromium.org, Jun 27 2017

Labels: Hotlist-Polish OS-Chrome
Status: Available (was: Untriaged)
Interesting. While I can also reproduce, I so far don't see where the error is in the code. Looking at setSavedPasswordsList_ in chrome/browser/resources/options/password_manager.js, the comparison is done after applying toLowerCase to both the search query and the credential fields.
I cannot investigate now, so marking this as Available.

Comment 7 by vabr@chromium.org, Jun 27 2017

Blocking: 714618
I have a CL up for this here: https://chromium-review.googlesource.com/c/600855
Cc: tbuck...@chromium.org dpa...@chromium.org hcarmona@chromium.org bettes@chromium.org
Labels: Proj-MaterialDesign-WebUI
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/879ed39c816c2f06b234c90a53f9b9f08d822852

commit 879ed39c816c2f06b234c90a53f9b9f08d822852
Author: Lenny Khazan <lenny.khazan@gmail.com>
Date: Fri Aug 04 22:44:38 2017

Make password filtering case insensitive

The password filter in chrome://settings/passwords is now case
insensitive.

Bug:  735867 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I24e5a6c0b4f07daf4e493be2c4be969c5146e9fb
Reviewed-on: https://chromium-review.googlesource.com/600855
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492158}
[modify] https://crrev.com/879ed39c816c2f06b234c90a53f9b9f08d822852/AUTHORS
[modify] https://crrev.com/879ed39c816c2f06b234c90a53f9b9f08d822852/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/879ed39c816c2f06b234c90a53f9b9f08d822852/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Status: Fixed (was: Available)
Assuming this is fixed now.

Sign in to add a comment