Regression: [DevTools] Nothing happens on clicking "Performance/Accessibility/Best Practice" under 'Audits' section.
Reported by
dchau...@etouch.net,
Jun 22 2017
|
|||
Issue descriptionChrome Version: 61.0.3138.0 (Official Build)d2d3a3975e9c7f3c5c62ef0ecad2683332894600-refs/heads/master@{#481386} 32/64-bit. OS: Windows (7,8,10), Mac (10.11.6, 10.12.3), Linux (14.04 LTS). What steps will reproduce the problem? 1. Launch chrome, go to www.fb.com open DevTools and go to 'Audits' section. 2. Run the audit by clicking on 'Perform an audit' and 'Run audit' buttons. 3. Now, click on "Performance/Accessibility/Best Practice" at right side and observe.(refer video) Nothing happens on clicking "Performance/Accessibility/Best Practice" option. It should navigate to corresponding section after clicking on "Performance/Accessibility/Best Practice" option. This is a regression issue, broken in M-61 series, below is manual regression range. Good build: 61.0.3135.0 Bad build: 61.0.3136.0 Kindly review the attached screen-cast for reference.
,
Jun 27 2017
,
Jun 28 2017
Issue 737436 has been merged into this issue.
,
Jul 7 2017
Just to Update,
This issue is observed on Mac 10.12.5 with latest dev #61.0.3141.7, Canary #61.0.3150.0. Since this is a RB-Stable, sunyunjia@ could you provide an latest update to this issue.
,
Jul 7 2017
We're currently working on it and have a patch under review: https://chromium-review.googlesource.com/c/550237/
,
Jul 11 2017
A friendly reminder that M61 branch is coming soon on 07/20! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix ASAP to trunk. This way we branch M61 from a high quality trunk. Thank you.
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c commit 6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c Author: Sandra Sun <sunyunjia@chromium.org> Date: Fri Jul 14 05:06:16 2017 smooth-scroll shouldn't be aborted by instant-scroll in the same chain. When performing a scrollIntoView, if some scrolling boxes in the chain has the smooth behavior while the others don't, the sequenced smooth scrolls shouldn't be aborted. This patch fixes the bug by setting the ScrollType to kSequencedSmoothScroll once we noticed a smooth scroll in the scroll chain, so that ScrollableArea::SetScrollOffset() will not abort the sequenced smooth scrolls. This patch also moves the first call of RunQueuedAnimations() to LayoutObject::ScrollRectToVisible() to make sure that all sequenced smooth scrolls get a chance to run. Bug: 735863 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8d72bcc873efcf82883ab7272328c3759789e7a3 Reviewed-on: https://chromium-review.googlesource.com/550237 Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#486682} [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/core/frame/LocalFrameView.cpp [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/core/frame/LocalFrameView.h [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/core/frame/RootFrameViewport.cpp [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/core/frame/RootFrameViewport.h [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/core/layout/LayoutBox.h [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/platform/scroll/ScrollTypes.h [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/platform/scroll/ScrollableArea.h [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/platform/scroll/SmoothScrollSequencer.cpp [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/platform/scroll/SmoothScrollSequencer.h [modify] https://crrev.com/6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c/third_party/WebKit/Source/web/tests/SmoothScrollTest.cpp
,
Jul 14 2017
,
Jul 17 2017
Retested this issue on Windows machine using latest Canary 61.0.3159.0 (Official Build).. It's seems to be fixed and working as intended i.e. It navigates to corresponding section after clicking on "Performance/Accessibility/Best Practice" option. Attaching screen-cast for the same. |
|||
►
Sign in to add a comment |
|||
Comment 1 by rbasuvula@chromium.org
, Jun 22 2017Labels: ReleaseBlock-Stable hasbisect-per-revison
Owner: sunyunjia@chromium.org
Status: Assigned (was: Unconfirmed)