New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 735856 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Jul 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

Notify NotificationPromoWhatsNew when the header is viewed

Project Member Reported by gambard@chromium.org, Jun 22 2017 
The NotificationPromoWhatsNew is never notified when the header is viewed in ContentSuggestions. Fix it.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e85076c9e6f8d2c9e3e6ca2860b5321d2299ce9

commit 1e85076c9e6f8d2c9e3e6ca2860b5321d2299ce9
Author: gambard <gambard@chromium.org>
Date: Thu Jul 06 08:39:40 2017

Notify NotificationPromoWhatsNew when the promo is viewed

The NotificationPromoWhatsNew needs to be notified when the promo is
viewed to increase its view count.

BUG= 735856 

Change-Id: Ia7109270265f81355422edcc403c33775f5c722b
Reviewed-on: https://chromium-review.googlesource.com/559348
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484499}
[modify] https://crrev.com/1e85076c9e6f8d2c9e3e6ca2860b5321d2299ce9/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/1e85076c9e6f8d2c9e3e6ca2860b5321d2299ce9/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[modify] https://crrev.com/1e85076c9e6f8d2c9e3e6ca2860b5321d2299ce9/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller_audience.h

Comment 2 by gambard@chromium.org, Jul 6 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment