Regression: Unnecessary autofill is seen for 'Email id' and 'password' field of facebook welcome page after saving password
Reported by
sans...@etouch.net,
Jun 22 2017
|
||||||||
Issue descriptionChrome Version: 61.0.3138.0 (Official Build) d2d3a3975e9c7f3c5c62ef0ecad2683332894600-refs/heads/master@{#481386} (32/64-bit) OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS) Steps: 1. Launch Chrome and sign to fb.com with valid credential 2. Save the password after sign in, then logout and observe welcome page Actual: Unnecessary autofill is seen for 'Email id' and 'password' field of facebook welcome page after saving password Expected: Autofill should not be seen 'Email id' and 'password' field of facebook welcome page after saving password This is a Regression issue broken in M-60, will soon update other info Good build: 60.0.3109.0 Bad build: 60.0.3110.0
,
Jun 22 2017
Using the per-revision bisect providing the bisect results, Good build:60.0.3109.0(Revision:474118). Bad build:60.0.3110.0(Revision:474499). You are probably looking for a change made after 474283 (known good), but no later than 474284 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/5c368544217d411cc810f1afe74cc86dd075b423..40f676517d2d8b840c41eb67a7f874a154e7f54a From the CL above, assigning the issue to the concern owner @vasilii: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://codereview.chromium.org/2900983002 Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3138.0 Adding Release Block-Stable for this issue.Please remove if not the case.
,
Jun 22 2017
,
Jun 22 2017
This is a consequence of r474284 where we stopped using the 'action' for autofill decision. I still think it's correct. Imagine this bug the other way around - credential is saved on sign up - it's not autofilled in the sign-in page. I think it's worse. Here the credential is relevant but we fill it into the sign-up form. The form doesn't use the autosign-in attributes. We even know that it's a sign-up form but the ping comes later after the page loaded. We can either - revert the CL accepting that there will be many cases when we don't autofill though we should - Leave the bug until we switch to "fill on account select" (still a plan) from autofill - Wait for the server-side ping before autofilling
,
Jun 22 2017
,
Jun 22 2017
sansari@ does this happens on other websites or just in fb?
,
Jun 23 2017
With response to comment #6, checked above issue for 'https://www.linkedin.com/' as this website also shows Sign up page like 'facebook' after logout. This issue is not observed for 'linkedin.com' Thank you.
,
Jun 23 2017
The bug happens on the sites which don't use the autocomplete attributes (https://www.chromium.org/developers/design-documents/form-styles-that-chromium-understands). We have been pushing those attributes for a while. There is a project now to add this information to the DevTools so that a web developer gets a recommendation to apply them. linkedin uses the attributes. FB doesn't and I already contacted them in hopes that they can fix it.
,
Jun 27 2017
Just to update, Still able to reproduce the issue on Ubuntu 14.04 using latest chrome version # 61.0.3141.0 vasilli@ Could you please look into this issue. Thanks!
,
Jun 29 2017
We discussed it with the team and decided that r474284 produces more benefits than disadvantages. Facebook has already fixed its homepage so that this bug is fixed. Regarding other pages. The long term solution will be to wait for the server side info about the form. As for now, the sites can fix their implementation to include the attributes.
,
Jun 29 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-60; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-60 label, otherwise remove Merge-TBD label. Thanks.
,
Jun 29 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ranjitkan@chromium.org
, Jun 22 2017