ChromeServiceWorkerNavigationHintTest is flaky because of HistogramTester |
||||
Issue descriptionRun browser_tests with "--gtest_filter=ChromeServiceWorkerNavigationHintTest.*" several times in Debug build. Expected: No crash Actual: sometimes crashes [45162:45162:0622/151946.519232:FATAL:lock_impl_posix.cc(63)] Check failed: rv == 0 (35 vs. 0). Resource deadlock avoided #0 0x7f4de10c856b base::debug::StackTrace::StackTrace() #1 0x7f4de10c726c base::debug::StackTrace::StackTrace() #2 0x7f4de113b723 logging::LogMessage::~LogMessage() #3 0x7f4de12549cd base::internal::LockImpl::Lock() #4 0x7f4de107fea3 base::Lock::Acquire() #5 0x7f4de107fb43 base::AutoLock::AutoLock() #6 0x7f4de11c84e3 base::StatisticsRecorder::RegisterOrDeleteDuplicateRanges() #7 0x7f4de11abf5b base::PersistentHistogramAllocator::CreateHistogram() #8 0x7f4de11ab8dd base::PersistentHistogramAllocator::GetHistogram() #9 0x7f4de11ab72d base::PersistentHistogramAllocator::Iterator::GetNextWithIgnore() #10 0x7f4de11af84b base::GlobalHistogramAllocator::ImportHistogramsToStatisticsRecorder() #11 0x7f4de11c93ab base::StatisticsRecorder::ImportGlobalPersistentHistograms() #12 0x7f4de11c8a00 base::StatisticsRecorder::GetSnapshot() #13 0x000002e4cfdd base::HistogramTester::HistogramTester() #14 0x0000012e19c1 (anonymous namespace)::ChromeServiceWorkerNavigationHintTest::RunNavigationHintTest() #15 0x0000012e27ad (anonymous namespace)::ChromeServiceWorkerNavigationHintTest_NoFetchHandler_Test::RunTestOnMainThread() #16 0x000003f2b67a content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #17 0x0000008c083d _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIP21RenderViewContextMenuJEEEvS4_OT_DpOT0_ #18 0x0000008c0751 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_ #19 0x000003f2d377 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #20 0x000003f2d2bc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #21 0x0000008a781d _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv #22 0x000003a184b2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #23 0x000003a17020 ChromeBrowserMainParts::PreMainMessageLoopRun() #24 0x7f4dd82578d1 content::BrowserMainLoop::PreMainMessageLoopRun() #25 0x7f4dd74d666d _ZN4base8internal13FunctorTraitsIMN7content13URLLoaderImplEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_ #26 0x7f4dd8260c51 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMN7content15BrowserMainLoopEFivEJPS5_EEEiOT_DpOT0_ #27 0x7f4dd8260bf7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #28 0x7f4dd8260b3c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #29 0x7f4dd74a290d _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv #30 0x7f4dd8f3821b content::StartupTaskRunner::RunAllTasksNow() #31 0x7f4dd82553a0 content::BrowserMainLoop::CreateStartupTasks() #32 0x7f4dd8264157 content::BrowserMainRunnerImpl::Initialize() #33 0x7f4dd825184f content::BrowserMain() #34 0x7f4dd9cbfef6 content::RunNamedProcessTypeMain() #35 0x7f4dd9cc23ed content::ContentMainRunnerImpl::Run() #36 0x7f4dd9cbeaca content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #37 0x7f4dcacc4ed1 service_manager::Main() #38 0x7f4dd9cbf94f content::ContentMain() #39 0x000003f2b36e content::BrowserTestBase::SetUp() #40 0x000002e37e70 InProcessBrowserTest::SetUp() #41 0x000000e2899e _ZN7testing8internal12InvokeHelperIvSt5tupleIJEEE12InvokeMethodI14ServiceProcessMS6_FvvEEEvPT_T0_RKS3_ #42 0x000001993332 testing::internal::HandleExceptionsInMethodIfSupported<>() #43 0x000001987e94 testing::Test::Run() #44 0x00000198869d testing::TestInfo::Run() #45 0x000001988c3f testing::TestCase::Run() #46 0x00000198dfec testing::internal::UnitTestImpl::RunAllTests() #47 0x000000e27f9e _ZN7testing8internal12InvokeHelperIbSt5tupleIJEEE12InvokeMethodI20MockServiceIPCServerMS6_FbvEEEbPT_T0_RKS3_ #48 0x000001994b62 testing::internal::HandleExceptionsInMethodIfSupported<>() #49 0x00000198dc8f testing::UnitTest::Run() #50 0x000002e55aa1 RUN_ALL_TESTS() #51 0x000002e54792 base::TestSuite::Run() #52 0x000002df3725 ChromeTestSuiteRunner::RunTestSuite() #53 0x000002df3829 ChromeTestLauncherDelegate::RunTestSuite() #54 0x000003fc281f content::LaunchTests() #55 0x000002df3b69 LaunchChromeTests() #56 0x000002df3615 main #57 0x7f4dc74acf45 __libc_start_main #58 0x00000081ccd4 <unknown> I think we should not create a HistogramTester while stopping the ServiceWorker.
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8290f1360214501d2dfd2734647c57576a1c49ef commit 8290f1360214501d2dfd2734647c57576a1c49ef Author: Tsuyoshi Horo <horo@chromium.org> Date: Thu Jun 22 20:54:49 2017 Fix flaky ChromeServiceWorkerNavigationHintTest We should not create a HistogramTester while stopping the ServiceWorker. Bug: 735814 Change-Id: Ie3d8197b90605162d78d219c130028e7fbb321fb Reviewed-on: https://chromium-review.googlesource.com/544359 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#481659} [modify] https://crrev.com/8290f1360214501d2dfd2734647c57576a1c49ef/chrome/browser/chrome_service_worker_browsertest.cc
,
Jun 23 2017
Seeing this crash from users since version 61.0.3130.3 affecting 50 unique users in Android: https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Android%27%20%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27RegisterOrDeleteDuplicateRanges%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt= Looks like something regressed in code?
,
Jun 23 2017
Users experienced this crash on the following builds: Android Dev 61.0.3136.4 - 1.93 CPM, 24 reports, 23 clients (signature RegisterOrDeleteDuplicateRanges) If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates. - Go/Fracas
,
Jun 25 2017
This issue is a bug of the test ChromeServiceWorkerNavigationHintTest. So this issue is not related any crash reports.
,
Jun 26 2017
Nevertheless, there are crashes in the wild with the RegisterOrDeleteDuplicateRanges magic signature, right? I filed issue 736675 against Internals>Metrics to track that. |
||||
►
Sign in to add a comment |
||||
Comment 1 by horo@chromium.org
, Jun 22 2017