New issue
Advanced search Search tips

Issue 735770 link

Starred by 2 users
Status: Verified
Owner:
cjgrant@chromium.org
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Offline chip does not appear in VR mode

Project Member Reported by est...@chromium.org, Jun 22 2017 
Chrome Version: 61.0.3137.0
OS: Android

What steps will reproduce the problem?
(1) Visit https://nytimes.com.
(2) From the menu, click the Download icon.
(3) Turn off wifi and navigate to https://nytimes.com. See the Offline chip in the omnibox.
(4) Go into VR mode.

What is the expected result?
Offline chip appears in VR mode, or boot out of VR mode.

What happens instead?
Normal (i) icon.

The Offline chip is a security indicator; it's the only way the user is notified that they're viewing a snapshot of a page (which may in future be delivered by an untrusted party or by a trusted party other than the website itself).

Comment 1 by cjgrant@chromium.org, Jun 22 2017

Owner: cjgrant@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by cjgrant@chromium.org, Jun 30 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0af1dee22043449ff2076b1ba361a47b1803b3d

commit d0af1dee22043449ff2076b1ba361a47b1803b3d
Author: cjgrant <cjgrant@chromium.org>
Date: Fri Jul 07 02:01:32 2017

ToolbarModel: Supply offline page status.

This allows users of ToolbarModel to determine whether the current page
is an offline page or not.  In the future, it'd be interesting if the
security level, vector icon and verbose security text could simply
indicate that the page is offline, rather than using a separate bit of
information.

BUG= 735770 

Review-Url: https://codereview.chromium.org/2965043003
Cr-Commit-Position: refs/heads/master@{#484789}

[modify] https://crrev.com/d0af1dee22043449ff2076b1ba361a47b1803b3d/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc
[modify] https://crrev.com/d0af1dee22043449ff2076b1ba361a47b1803b3d/chrome/browser/android/vr_shell/toolbar_helper.cc
[modify] https://crrev.com/d0af1dee22043449ff2076b1ba361a47b1803b3d/chrome/browser/android/vr_shell/toolbar_state.cc
[modify] https://crrev.com/d0af1dee22043449ff2076b1ba361a47b1803b3d/chrome/browser/android/vr_shell/toolbar_state.h
[modify] https://crrev.com/d0af1dee22043449ff2076b1ba361a47b1803b3d/chrome/browser/ui/toolbar/chrome_toolbar_model_delegate.cc
[modify] https://crrev.com/d0af1dee22043449ff2076b1ba361a47b1803b3d/chrome/browser/ui/toolbar/chrome_toolbar_model_delegate.h
[modify] https://crrev.com/d0af1dee22043449ff2076b1ba361a47b1803b3d/components/toolbar/test_toolbar_model.cc
[modify] https://crrev.com/d0af1dee22043449ff2076b1ba361a47b1803b3d/components/toolbar/test_toolbar_model.h
[modify] https://crrev.com/d0af1dee22043449ff2076b1ba361a47b1803b3d/components/toolbar/toolbar_model.h
[modify] https://crrev.com/d0af1dee22043449ff2076b1ba361a47b1803b3d/components/toolbar/toolbar_model_delegate.h
[modify] https://crrev.com/d0af1dee22043449ff2076b1ba361a47b1803b3d/components/toolbar/toolbar_model_impl.cc
[modify] https://crrev.com/d0af1dee22043449ff2076b1ba361a47b1803b3d/components/toolbar/toolbar_model_impl.h
[modify] https://crrev.com/d0af1dee22043449ff2076b1ba361a47b1803b3d/ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.h
[modify] https://crrev.com/d0af1dee22043449ff2076b1ba361a47b1803b3d/ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.mm

Comment 4 Deleted

Comment 5 by cjgrant@chromium.org, Jul 7 2017 

The CL that will enable the offline chip in review here:

https://codereview.chromium.org/2968143003/

There are follow-on TO-DO items, which presumably don't gate M-61:

- crbug/740160: Determine final offline security chip text color
- crbug/740112: Properly trim scheme from offline page URL

Comment 7 by vollick@chromium.org, Jul 11 2017

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0efbb839fe6d0864c4b8cf350e013a2f362fc592

commit 0efbb839fe6d0864c4b8cf350e013a2f362fc592
Author: Ian Vollick <vollick@chromium.org>
Date: Tue Jul 11 16:32:27 2017

[vr] Update comment in url_bar_texture.cc

This CL makes the changes to the comment prose suggested
in the review of https://codereview.chromium.org/2968143003/

BUG:  735770 
Change-Id: I9b3a58a36100be223b3c5ce36b31087579bdf2c5
Reviewed-on: https://chromium-review.googlesource.com/565845
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485649}
[modify] https://crrev.com/0efbb839fe6d0864c4b8cf350e013a2f362fc592/chrome/browser/vr/elements/url_bar_texture.cc

Comment 9 by vsupruniuk@google.com, Jul 25 2017

Status: Verified (was: Fixed)
Verified in Chrome Canary 62.0.3165.0
►

Sign in to add a comment