New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735769 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Credential management API dialog in VR mode opens 2D dialog

Project Member Reported by est...@chromium.org, Jun 22 2017

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Visit tinyurl.com/credmng11.
(2) Click Sign-In, and Allow on the infobar.
(3) Sign out and refresh.
(4) Go into VR mode and click Sign In.

What is the expected result?
Boot out of VR mode?

What happens instead?
2D dialog appears over the VR content

Similar to  issue 735766 . Not a security issue, just general usability.
 
Owner: asimjour@chromium.org
Status: Assigned (was: Untriaged)
Cc: asimjour@chromium.org billorr@chromium.org
Owner: ----
Status: Available (was: Assigned)
Owner: billorr@chromium.org
Status: Assigned (was: Available)
ChromePasswordManagerClient::PromptUserToChooseCredentials is where we try to show the dialog.  This looks like a reasonable place to decide not to show the dialog.
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/871c5d1221b7ae6a3a6be3a7c7880c4190bafeea

commit 871c5d1221b7ae6a3a6be3a7c7880c4190bafeea
Author: billorr <billorr@chromium.org>
Date: Tue Jul 04 05:17:46 2017

Disable Credential management API dialog in VR mode

2D popups can cause discomfort while in VR.  This change disables the 2D
Credential management UI while in VR mode.

BUG= 735769 

Review-Url: https://codereview.chromium.org/2958533003
Cr-Commit-Position: refs/heads/master@{#484053}

[modify] https://crrev.com/871c5d1221b7ae6a3a6be3a7c7880c4190bafeea/chrome/browser/password_manager/chrome_password_manager_client.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment