Add StoryExpectation support to perf_data_generator |
||
Issue descriptionThis script outputs the tests we want to run. It needs to be able to understand PermanentlyDisabledBenchmark in story expectations to know not to try and schedule the benchmarks.
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb999da859b880bb285037fb6481868d7250e19f commit eb999da859b880bb285037fb6481868d7250e19f Author: Ned Nguyen <nednguyen@google.com> Date: Wed Sep 06 21:18:05 2017 Fix bug in perf_data_generator when there is unscheduled benchmark When user add a new benchmark, we typically need to find an appropriate bot in each builder to add that new benchmark to so that the shards are not too unbalanced. Since such operation is complicated, it's done by benchmarking team member and not by end users. To unblock the CL that adds the benchmark & bypass perf_data_generator check, we ask the user to disable that benchmark completely through "@benchmarks.Disabled('all')" However, as we are moving away from using decorator for disabling benchmark (see https://groups.google.com/a/chromium.org/forum/#!topic/telemetry-announce/nbA3jOUh4Uk), that no longer works. The core bug here is perf_data_generator currently doesn't support the logic to determine whether a benchmark is completely disabled on all platform. However, I intend to not go down this path as the logic of determining whether a benchmark should be scheduled on perf_data_generator is already convoluted (see ShouldBenchmarksBeScheduled, https://cs.chromium.org/chromium/src/tools/perf/core/perf_data_generator.py?q=perf_data_generator.py&dr&l=694) Instead, this CL fixes it by adding _UNSCHEDULED_TELEMETRY_BENCHMARKS set that store all the benchmarks which are temporarily disabled. Bug: 735762 Change-Id: Ib5726f6bea47510f19374f871b4d2e2f557444c1 Reviewed-on: https://chromium-review.googlesource.com/652507 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#500089} [modify] https://crrev.com/eb999da859b880bb285037fb6481868d7250e19f/tools/perf/core/perf_data_generator.py
,
Aug 2
|
||
►
Sign in to add a comment |
||
Comment 1 by nedngu...@google.com
, Jun 22 2017Status: Assigned (was: Untriaged)