Issue metadata
Sign in to add a comment
|
76.5%-138.4% regression in memory.desktop at 480471:480724 |
||||||||||||||||||||||||
Issue descriptionTotal run time of memory.desktop benchmarks are doubled of many platforms (20 minutes --> 40 minutes). Is this due to the heap profiler enabled?
,
Jun 22 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8976131952630477376
,
Jun 22 2017
,
Jun 22 2017
This seems quite likely. Do you expect us to do anything about this? native heap profiling provides: 1) Much higher reliability metrics for memory usage [significantly lower noise] 2) Better ability to debug regressions.
,
Jun 22 2017
This bug is mostly about the regression of benchmark duration. This is particular important if we want to keep the benchmark cycle fast, but if the heap profiling does help with (1) & (2), I think the trade off worths it. For this bug, all I want is verifying that the jump on the benchmark duration is due to native heap profiling and not something else.
,
Jun 22 2017
No, the regression range doesn't match up. https://chromium.googlesource.com/chromium/src/+log/808540a1356b6cc5bebaf0eabc15a333823985df%5E..35c710a8c0271ada62f0a4096412ac521041ce65?pretty=fuller
,
Jun 22 2017
Reassign to you for triaging investigating this (since you are listed as this benchmark's owner).
,
Jun 22 2017
=== Auto-CCing suspected CL author dskiba@chromium.org === Hi dskiba@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : dskiba Commit : d4a5e98235da0cc8c4fb1ae2f67826b0b480ce4c Date : Mon Jun 19 21:10:15 2017 Subject: [tracing] Switch to new heap dump format. Bisect Details Configuration: winx64_high_dpi_perf_bisect Benchmark : memory.desktop Metric : benchmark_duration/benchmark_duration Change : 110.56% | 5.007797222 -> 10.5443194456 Revision Result N chromium@480554 5.0078 +- 0.225949 6 good chromium@480573 5.07019 +- 0.371097 6 good chromium@480578 4.96399 +- 0.250694 6 good chromium@480579 5.11791 +- 0.212178 6 good chromium@480580 10.4529 +- 0.160198 6 bad <-- chromium@480581 10.4491 +- 0.278276 6 bad chromium@480583 10.3535 +- 0.454461 6 bad chromium@480592 10.3818 +- 0.425868 6 bad chromium@480629 10.5012 +- 0.327179 6 bad chromium@480703 10.5443 +- 0.291315 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.desktop Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8976131952630477376 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5262439446216704 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jul 5 2017
,
Jan 16
,
Jan 16
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by nedngu...@google.com
, Jun 22 2017