Context menu download will proceed even if user don't grant Storage permission |
|||||
Issue descriptionin https://chromium.googlesource.com/chromium/src/+/60.0.3112.41/chrome/browser/android/download/download_controller.cc, we didn't check the input grant param in CreateContextMenuDownload(). If grant is false, we should early return, rather than proceeding the download. The issue is fixed on trunk by https://chromium-review.googlesource.com/c/541684/. Requesting a merge of line 76-80 of https://chromium-review.googlesource.com/c/541684/9/chrome/browser/android/download/download_controller.cc#79
,
Jun 22 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 22 2017
Approved for M60 branch 3112.
,
Jun 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22b5ccf95c26128e6293faaea531cc130682ce9a commit 22b5ccf95c26128e6293faaea531cc130682ce9a Author: Min Qin <qinmin@chromium.org> Date: Fri Jun 23 16:42:16 2017 early return if user denies storage permission Bug= 735745 TBR=dtrainor@chromium.org (cherry picked from commit 2cc12536a8b000ea3e2e4e289b2a9b1989757336) Change-Id: Idb43dc03cd14c99488d253a8a76bd7685ce53cb6 Reviewed-on: https://chromium-review.googlesource.com/541684 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#481113} Bug: Reviewed-on: https://chromium-review.googlesource.com/546256 Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#449} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/22b5ccf95c26128e6293faaea531cc130682ce9a/chrome/browser/android/download/download_controller.cc
,
Aug 1 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by qin...@chromium.org
, Jun 22 2017