Can not get axis data while in VR mode
Reported by
kvis....@gmail.com,
Jun 21 2017
|
||||||||
Issue descriptionSteps to reproduce the problem: 1. make some code to work with gamepads 2. make some code to work with vr What is the expected behavior? pressing gamepad axis make some changes to my code (it works great), enter VR, nothing works What went wrong? gamepad.axis data always [0,0,0,0] Did this work before? N/A Does this work in other browsers? N/A Chrome version: 59.0.3071.86 Channel: stable OS Version: 5 Flash Version:
,
Aug 1 2017
Just wanted to file the same issue: Gamepad API doesn't work in WebVR mode, tested on M61.xxxx.12. The reason why - the ContentViewCore doesn't receive dispatchKeyEvent and onGenericMotionEvent due to detached view (it gets detached once entering WebVR mode). The way to fix: manually propagate dispatchKeyEvent & onGenericMotionEvent from ChromeTabbedActivity to mContentViewCore when in WebVR mode.
,
Aug 2 2017
BTW, I've created a test case for gamepads-in-WebVR testing: https://artyom17.github.io/webvr.info/samples/XX-gamepads.html
,
Aug 10 2017
Thanks for the investigative work to figure out where the issue originated!
,
Sep 8 2017
,
Sep 11 2017
Michael, is this something we can and should add to the manual testing plan?
,
Sep 14 2017
Not sure. Thoughts leilei?
,
Sep 14 2017
I don't think it is easy to do manual test, but we can add one automated test to cover it.
,
Sep 14 2017
If I understand correctly, this wouldn't be testable in ContentShell, so layout tests w/ mocking isn't an option. We should be able to create a mock gamepad device in Java, though.
,
Oct 18 2017
We should really get this fixed...
,
Nov 17 2017
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/285d7a4fbe0059f85fdfe3ba0e716e7b3c08fcb2 commit 285d7a4fbe0059f85fdfe3ba0e716e7b3c08fcb2 Author: Michael Thiessen <mthiesse@chromium.org> Date: Wed Nov 22 15:42:56 2017 VR: Connect gamepad and keyboard input to content while in VR. Note: I've only tested that keyboard works, but gamepad follows the same path and the fix is trivial. Also note that gamepads and physical keyboards won't currently work for VR browser UI. Bug: 735726 Change-Id: I7d4fe38a21a0ba8baad7362400db0d1cf63e57c3 Reviewed-on: https://chromium-review.googlesource.com/783793 Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#518641} [modify] https://crrev.com/285d7a4fbe0059f85fdfe3ba0e716e7b3c08fcb2/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
Nov 22 2017
Alright, I think this is fixed, but I couldn't get my xbox controller to work with my phone so I wasn't able to actually test a gamepad. I did test a usb keyboard and that worked. Please re-open if gamepads still don't work.
,
Jul 4
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ddorwin@chromium.org
, Jun 22 2017Labels: Proj-VR