MediaRouterMojoExtensionTest Should Not Change Behavior Based off of System Configuration |
||
Issue descriptionWith COM initialization in MediaRouterMojoImplUnittest, the firewall check requests now complete successfully on Windows. If the Windows Firewall contains a rule for unit_tests.exe, an unexpected task is posted to pending_request_ in the media router during SetUp(), failing the rest of the test. media_router::MediaRouterMojoImpl::EnqueueTask [0x032B5987+32] media_router::MediaRouterMojoImpl::RunOrDefer [0x032B804A+575] media_router::MediaRouterMojoImpl::EnsureMdnsDiscoveryEnabled [0x032B5B1D+66] media_router::MediaRouterMojoImpl::OnFirewallCheckComplete [0x032B636E+14] base::internal::FunctorTraits<void (__thiscall chrome::UnloadController::*)(bool),void>::Invoke<base::WeakPtr<chrome::UnloadController>,bool> [0x048E9DB5+26] [Callback Invocation] base::internal::Invoker<base::internal::BindState<base::Callback<void __cdecl(bool),1,1>,bool>,void __cdecl(void)>::Run [0x004975F3+19] base::debug::TaskAnnotator::RunTask [0x024F8229+409] base::MessageLoop::RunTask [0x02477AF1+1233] base::MessageLoop::DoWork [0x02476E9D+765] base::MessagePumpForUI::DoRunLoop [0x024EE06D+93] base::MessagePumpWin::Run [0x024EE7FA+74] base::MessageLoop::Run [0x0247760B+107] base::RunLoop::Run [0x024649E3+147] base::RunLoop::RunUntilIdle [0x02464AC3+99] extensions::WebRequestRulesRegistryTest::TearDown [0x00AAC4B5+21] media_router::MediaRouterMojoExtensionTest::SetUp [0x00859BE1+401] testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x00DE60BD+32] Components based on http://crbug.com/464216
,
Jun 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36088764facdace5cbf05517bfa0d1809d5553bd commit 36088764facdace5cbf05517bfa0d1809d5553bd Author: Robert Liao <robliao@chromium.org> Date: Fri Jun 23 00:23:05 2017 Stop Running Firewall Checks for MediaRouterMojoExtensionTest The firewall checks weren't running before, and with the upcoming COM initialization change for TestBrowserThreadBundle, they'll suddenly start running, changing all of the assumptions for the MediaRouterMojoExtensionTest. This change disables firewall checking for tests. BUG= 735725 Change-Id: I6e6760ab42cf9d5180cfa33028fb3fb973a45f1f Reviewed-on: https://chromium-review.googlesource.com/544900 Reviewed-by: Derek Cheng <imcheng@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#481741} [modify] https://crrev.com/36088764facdace5cbf05517bfa0d1809d5553bd/chrome/browser/media/router/mojo/media_router_mojo_impl.cc [modify] https://crrev.com/36088764facdace5cbf05517bfa0d1809d5553bd/chrome/browser/media/router/mojo/media_router_mojo_impl.h [modify] https://crrev.com/36088764facdace5cbf05517bfa0d1809d5553bd/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
,
Jun 23 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by robliao@chromium.org
, Jun 21 2017