New issue
Advanced search Search tips

Issue 735722 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Make WebappDirectoryManager#findStaleWebappDirectories() work for WebAPKs

Project Member Reported by pkotw...@chromium.org, Jun 21 2017

Issue description

Make WebappDirectoryManager#findStaleWebappDirectories() work for WebAPKs

The function seems to have a bunch of webapp specific stuff

 
Owner: yfried...@chromium.org
Status: Started
I'm doing this as part of  issue 735060 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ff213a88961f80fab0e21a871b62eb4336f3cb0

commit 5ff213a88961f80fab0e21a871b62eb4336f3cb0
Author: yfriedman <yfriedman@chromium.org>
Date: Mon Jun 26 14:21:32 2017

Change WebApk app-id prefix from 'webapk:' to 'webapk-'

This fixes some code which uses the host of a WebApp for various processing.
Specifically, when examining history state
(https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java?type=cs&q=liveWebapps.add+package:%5Echromium$&l=111)
this would fail because 'webapk:' becomes the host name.

This also makes WebApk id's consistent with traditional A2HS ids.
Finally, this includes a change to the cleanup routine run on WebApps to age out the old entries.
We will lose install source as part of this but it's just metrics book-keeping for us and doesn't affect users.
BUG= 735060 , 735722 

Review-Url: https://codereview.chromium.org/2952023002
Cr-Commit-Position: refs/heads/master@{#482267}

[modify] https://crrev.com/5ff213a88961f80fab0e21a871b62eb4336f3cb0/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java
[modify] https://crrev.com/5ff213a88961f80fab0e21a871b62eb4336f3cb0/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappDirectoryManagerTest.java
[modify] https://crrev.com/5ff213a88961f80fab0e21a871b62eb4336f3cb0/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java
[modify] https://crrev.com/5ff213a88961f80fab0e21a871b62eb4336f3cb0/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 10 2017

Labels: merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b2a6269e945ebf038f2377f3637b044deff6aa1

commit 8b2a6269e945ebf038f2377f3637b044deff6aa1
Author: Yaron Friedman <yfriedman@chromium.org>
Date: Mon Jul 10 17:26:56 2017

Change WebApk app-id prefix from 'webapk:' to 'webapk-'

This fixes some code which uses the host of a WebApp for various processing.
Specifically, when examining history state
(https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java?type=cs&q=liveWebapps.add+package:%5Echromium$&l=111)
this would fail because 'webapk:' becomes the host name.

This also makes WebApk id's consistent with traditional A2HS ids.
Finally, this includes a change to the cleanup routine run on WebApps to age out the old entries.
We will lose install source as part of this but it's just metrics book-keeping for us and doesn't affect users.
BUG= 735060 , 735722 
TBR=pkotwicz

(cherry picked from commit 5ff213a88961f80fab0e21a871b62eb4336f3cb0)

Review-Url: https://codereview.chromium.org/2952023002
Cr-Original-Commit-Position: refs/heads/master@{#482267}
Change-Id: Ib52aea4f06752504b697f9d2e81ad22ec65c0be7
Reviewed-on: https://chromium-review.googlesource.com/565463
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#558}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/8b2a6269e945ebf038f2377f3637b044deff6aa1/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java
[modify] https://crrev.com/8b2a6269e945ebf038f2377f3637b044deff6aa1/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappDirectoryManagerTest.java
[modify] https://crrev.com/8b2a6269e945ebf038f2377f3637b044deff6aa1/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java
[modify] https://crrev.com/8b2a6269e945ebf038f2377f3637b044deff6aa1/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

Sign in to add a comment