Add Suggested and All apps chip to the peeking and fullscreen launcher |
|||||
Issue descriptionAdd the chips on top of suggested and all apps, as per the spec.
,
Jun 21 2017
happy to take this one if no one is started
,
Jun 21 2017
,
Jun 21 2017
All yours, but it's currently blocked crbug.com/735702
,
Jun 21 2017
i can take that one too. Again, if you haven't started.
,
Jun 21 2017
Thanks, all yours!
,
Jun 27 2017
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc6f4ff899528aeb24316593094644c2b00e1178 commit fc6f4ff899528aeb24316593094644c2b00e1178 Author: Qiang Xu <warx@chromium.org> Date: Wed Jun 28 22:12:22 2017 cros: all apps page #02 UI specifications changes: This CL is mainly dealing with the UI layout of all apps page #02 and all subsequent pages. (1) 5 rows 5 cols (2) search box: 24px top padding, 21px bottom padding, fixed width (no longer in line with apps grid view's width. (3) add all apps indicator chip, 8px bottom padding with apps grid. (4) apps grid: 24px horizontal padding, 12px vertical padding. (5) page switcher view: remove 24px padding for its width. UI specification: https://screenshot.googleplex.com/0A4VEH19ukJ WIP screenshot: https://screenshot.googleplex.com/hmWYqP99kPJ TODO: page switcher view layout. flag, attached screenshot. R: xiyuan@chromium.org Bug: 735702 , 735709 TEST: tested with and without --enable-features=EnableFullscreenAppList Change-Id: I26b065f40e9e0f5338a64b04926e8c52b90da16d Reviewed-on: https://chromium-review.googlesource.com/551484 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#483166} [modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/app_list_constants.cc [modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/app_list_constants.h [modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/apps_container_view.cc [modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/apps_container_view.h [modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/apps_grid_view.cc [modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/contents_view.cc [modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/contents_view.h [modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/page_switcher_vertical.cc [modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/start_page_view.cc
,
Jul 6 2017
Dup into issue 735702 , as these two are strongly related. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by newcomer@chromium.org
, Jun 21 2017