New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735709 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 735702
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocked on:
issue 735702

Blocking:
issue 734164



Sign in to add a comment

Add Suggested and All apps chip to the peeking and fullscreen launcher

Project Member Reported by newcomer@chromium.org, Jun 21 2017

Issue description

Add the chips on top of suggested and all apps, as per the spec.
 
Labels: -Type-Bug -Pri-3 OS-Chrome Pri-1 Type-Feature

Comment 2 by warx@chromium.org, Jun 21 2017

Blocking: 734164
Cc: -warx@chromium.org newcomer@chromium.org
Owner: warx@chromium.org
Status: Assigned (was: Untriaged)
happy to take this one if no one is started

Comment 3 Deleted

Blockedon: 735702

Comment 5 Deleted

All yours, but it's currently blocked  crbug.com/735702 

Comment 7 by warx@chromium.org, Jun 21 2017

i can take that one too. Again, if you haven't started.
Thanks, all yours!

Comment 9 by warx@chromium.org, Jun 27 2017

Labels: NewLauncherUIV1
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc6f4ff899528aeb24316593094644c2b00e1178

commit fc6f4ff899528aeb24316593094644c2b00e1178
Author: Qiang Xu <warx@chromium.org>
Date: Wed Jun 28 22:12:22 2017

cros: all apps page #02 UI specifications

changes:
This CL is mainly dealing with the UI layout of all apps page #02 and
all subsequent pages.
(1) 5 rows 5 cols
(2) search box: 24px top padding, 21px bottom padding, fixed width (no
longer in line with apps grid view's width.
(3) add all apps indicator chip, 8px bottom padding with apps grid.
(4) apps grid: 24px horizontal padding, 12px vertical padding.
(5) page switcher view: remove 24px padding for its width.

UI specification: https://screenshot.googleplex.com/0A4VEH19ukJ
WIP screenshot: https://screenshot.googleplex.com/hmWYqP99kPJ

TODO: page switcher view layout.

flag, attached screenshot.

R: xiyuan@chromium.org
Bug:  735702 ,  735709 
TEST: tested with and without --enable-features=EnableFullscreenAppList
Change-Id: I26b065f40e9e0f5338a64b04926e8c52b90da16d
Reviewed-on: https://chromium-review.googlesource.com/551484
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483166}
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/app_list_constants.cc
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/app_list_constants.h
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/apps_container_view.cc
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/apps_container_view.h
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/contents_view.cc
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/contents_view.h
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/page_switcher_vertical.cc
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/start_page_view.cc

Comment 11 by warx@chromium.org, Jul 6 2017

Mergedinto: 735702
Status: Duplicate (was: Assigned)
Dup into  issue 735702 , as these two are strongly related.

Sign in to add a comment