On App Highlight via tab, add a rectangle |
|||||||
Issue descriptionWhen the user enters a keyboard tab, highlight the application using a rounded rectangle of #FFF 12% as well as the expand arrow with a #FFF 12% circle.
,
Jun 22 2017
,
Jun 27 2017
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/342afc7737e47aea1d7b2bf461fd2c40be2e19eb commit 342afc7737e47aea1d7b2bf461fd2c40be2e19eb Author: Qiang Xu <warx@chromium.org> Date: Tue Jun 27 19:33:49 2017 cros: add new highlight rounded rectangle to selected suggested/all apps Changes: (1) For keyboard focus, highlights the app using a rounded rectangle of FFF 12% for both suggested and all apps. (2) also in this CL, fix the preferred size of indicator chip view. (3) also in this CL, fix the left margin issue of suggested app tiles, so that they are horizontally centered in the screen. screenshot of suggested apps tiles: https://screenshot.googleplex.com/EoQA0rLFYKM screenshot of all apps tiles: https://screenshot.googleplex.com/vT1366vaXuj Bug: 735708 TEST: tested with and without --enable-features=EnableFullscreenAppList Change-Id: Ie634cb94de7ac1c18526228dafd71b9b5f642a62 Reviewed-on: https://chromium-review.googlesource.com/548240 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#482713} [modify] https://crrev.com/342afc7737e47aea1d7b2bf461fd2c40be2e19eb/ui/app_list/app_list_constants.cc [modify] https://crrev.com/342afc7737e47aea1d7b2bf461fd2c40be2e19eb/ui/app_list/app_list_constants.h [modify] https://crrev.com/342afc7737e47aea1d7b2bf461fd2c40be2e19eb/ui/app_list/views/app_list_item_view.cc [modify] https://crrev.com/342afc7737e47aea1d7b2bf461fd2c40be2e19eb/ui/app_list/views/indicator_chip_view.cc [modify] https://crrev.com/342afc7737e47aea1d7b2bf461fd2c40be2e19eb/ui/app_list/views/search_result_tile_item_view.cc [modify] https://crrev.com/342afc7737e47aea1d7b2bf461fd2c40be2e19eb/ui/app_list/views/start_page_view.cc [modify] https://crrev.com/342afc7737e47aea1d7b2bf461fd2c40be2e19eb/ui/app_list/views/suggestions_container_view.cc [modify] https://crrev.com/342afc7737e47aea1d7b2bf461fd2c40be2e19eb/ui/app_list/views/tile_item_view.cc [modify] https://crrev.com/342afc7737e47aea1d7b2bf461fd2c40be2e19eb/ui/app_list/views/tile_item_view.h
,
Jun 27 2017
,
Jun 27 2017
Not really fixed all of them: after the expand arrow view is updated, we shall add focus highlight to it.
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b80af55bbd0fc71afbdbfdaa95160e8947bf4b0e commit b80af55bbd0fc71afbdbfdaa95160e8947bf4b0e Author: Qiang Xu <warx@chromium.org> Date: Fri Jun 30 16:28:59 2017 cros: keyboard focus for expand arrow button changes: (1) When expand arrow selected, draw a #FFF 12%, 18px radius circle. (2) add keyboard focus behaviors related with expand arrow button: a. when expand arrow selected: arrow up/arrow left/shift-tab move focus to the last suggestion tile, arrow right/tab move focus to the first suggestion tile. b. when focus is inside suggestions container, arrow down would move focus to expand arrow button; when focus is at the last tile of suggestions, arrow right would move focus to expand arrow button. c. tab/shift-tab just work as usual. tested with and without --enable-features=EnableFullscreenAppList Bug: 735708 , 734164 TEST: screenshot of highlight: https: //screenshot.googleplex.com/YdFbRnKVXyF Change-Id: Ice124bb69123b1331608c6a45b17a0debdc6335c Reviewed-on: https://chromium-review.googlesource.com/557464 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#483728} [modify] https://crrev.com/b80af55bbd0fc71afbdbfdaa95160e8947bf4b0e/ui/app_list/views/expand_arrow_view.cc [modify] https://crrev.com/b80af55bbd0fc71afbdbfdaa95160e8947bf4b0e/ui/app_list/views/expand_arrow_view.h [modify] https://crrev.com/b80af55bbd0fc71afbdbfdaa95160e8947bf4b0e/ui/app_list/views/start_page_view.cc
,
Jun 30 2017
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by warx@chromium.org
, Jun 21 2017Cc: -warx@chromium.org newcomer@chromium.org
Owner: warx@chromium.org
Status: Assigned (was: Untriaged)