New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735705 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[Component Request] InstalledWebApps

Project Member Reported by benwells@chromium.org, Jun 21 2017

Issue description

1] Component Name: InstalledWebApps

Guideline 1 (Clarity): Component name should be descriptive beyond the core
project team
(i.e. please avoid using non-industry standard abbreviations, code words,
project names, etc...)

Guideline 2 (Permanence): Component names should describe features/
functions and not team names, code locations, etc..., which are more
subject to change and make the hierarchy less predictable for people
triaging issues.

Guideline 3 (Specific): Components are meant to explicitly track functional
work areas.  If you are trying to track a Proj(ect) or an on-going effort
(e.g. Hotlist-Conops), please instead request a label for a (Proj- or
Hotlist-)

Guideline 4 (Discoverable/ Predictable): Components should be parented
where people would logically expect to find them (i.e. follow product
decomposition when naming versus team decomposition)

2] Parent Component (e.g. Blink, UI>Browser, etc...): UI>Browser

Note: We generally avoid creating new component namespaces, unless there is
a new hierarchy that needs to be expressed.  Please try and use existing
components as parents.

3] Description of Component: Issues related to installation of web apps and the UI of running web apps. Component is not for issues related to WebAPK minting.

4] Admin/ Owner: benwells@

5] Please specify what triage practices will be followed for the component
(i.e. what team will do it and how frequently).

team: chrome-installability@. Triage rotation and dashboard to be setup once component created.

 
Ping ...
Cc: jrobbins@chromium.org
Owner: lafo...@chromium.org
I believe this is still the recommended practice for filing a component request?  Anthony, can you follow up?
Will these just be referred to as ProgressiveWebApps externally?
This is a bit distinct from general PWAs in a couple of ways (at least):
1. Non-PWAs can be installed manually
2. PWAs don't need to be installed.
Is there a way that this can be described w/ out a negative (i.e. with current phrasing this will appear if someone types webapk)?
Ah ... ok. It probably does make sense for this to come up when users type WebAPKs. For example I just looked at an issue that had been put in WebAPKs incorrectly. How is this:

Issues related to the Chrome side handling of installation of web apps and the UI of running installed web apps. Installed web apps include WebAPKs on Android and web apps added to the desktop / shelf etc. on desktop platforms. For server side issues related to WebAPKs (e.g. minting issues) or issues with the code inside the WebAPK bundle use Mobile>WebAPKs.
Cc: piotrs@chromium.org
+piotrs who is interested in this.

laforge - any progress?
Cc: owe...@chromium.org
+Owen.  The description is a little long and seems a bit ambiguous (i.e. installing web apps doesn't clearly distinguish from APK minting, add to shelf, app shortcuts, PWAs, etc...).

Perhaps there is a way to shift things around around a little to express these potentially related/ distinct concepts in a slightly different hierarchy.
A short version would be "Issues related to the Chrome handling of the installation of web apps and the UI or running installed web apps."

The distinguishing factor is that it is related to the code in Chrome, not code in minting servers or the APK itself. Anyway, hopefully someone else can come up with a short-enough precise-enough description.

BTW where are these descriptions visible? AFAIK I've never seen a component description.
The descriptions appear next the component, in the auto-complete drop down.

Let's put a pin on this for a moment.  I'd like to get some additional perspective from Owen about the right naming/ structure.

As an aside, we omit the phrase "Issues related to...," since components explicitly only contain issues.

Comment 11 by piotrs@google.com, Jul 12 2017

Shorter version proposal while we wait for Owen:

"Install flow and UX in installed web apps"
Ah right, I see - that helps a lot! The components I typically use don't have any description :/

I can see now that these are useful and typically only a few words long. Sure, let's wait for Owen.

Is there pressure to keep the number of components low? Maybe we could split this into a few components:
> Installability - Installability checking of PWAs
> InstallationFlow - Web app installation UI and flow

Note the last once includes non-PWAs - any web site can be installed manually, but PWAs get special promotion.

And another one, maybe:
> UX - UX of installed web apps.

not sure if that name is OK.

It would help a lot if these components got descriptions:
Mobile>WebAPKs
Content>WebApps

Also Browser>AppShortcuts probably should be deprecated, if that can be done. It was used for the very old 'create application shortcuts' feature which has been replaced with all this new stuff.
pinging Owen! Please add your 2c.
Adding my 2ยข - I see a few different kinds of issues:

1. Issues pertaining to Chrome's install UI features and triggering. This applies to PWA and non-PWA, desktop and mobile.
2. Issues pertaining to the UX of running an "installed web app". Again applies to PWA and non-PWA, desktop and mobile
3. Issues pertaining to the backend generating WebAPKs

And for completness, note the former two sets of issues are both owned by the Sydney team while the latter are owned by the WebAPK team.

I don't have a view about whether we should split 1 and 2 into separate components, would like to know what laforge thinks about that.

As a strawman I'd suggest WebAppInstalls as a new component for 1 and 2. Note I find "installability" implies pre-installed and "InstalledWebApp" implies post-installed only, hence avoiding either "Installability" or "installed". A description for this could be as Piotr suggests: "Web app install flow and UX of installed web apps"

We could consider trying to split this by desktop and mobile into separate components, but I can't find any particularly clean way to do that since some things are shared. Since it's the same team handling both I'd suggest for now we don't worry about that and instead use the OS fields to manage that divide.

Comment 15 by piotrs@google.com, Aug 29 2017

Hi Laforge, what should be the next step to move this forward? Thanks!
Hi again, summing up all of above and after checking with the team I proposal following:

We deprecate/remove:
UI>Browser>AppShortcuts - old replaced feature.
Content>WebApps - shouldn't be used (consulted with Dom), we will move out of it.

We introduce:
UI>Browser>WebAppInstalls - "Install flow and UX in installed web apps, including WebApks"

We add descriptions:
Mobile>WebAPKs - "WebAPK minting and WebAPK specific handling in Chrome"

Let me know whether above is feasible.
Components: UI>Browser>WebAppInstalls
Status: Fixed (was: Untriaged)
All of those are now done (deprecated, created, and updated as appropriate).  Thank you for summarizing and syncing on the items that can be removed.

Comment 18 by piotrs@google.com, Sep 7 2017

Thank you Anthony!

Sign in to add a comment