New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735702 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocked on:
issue 736791
issue 740321

Blocking:
issue 735709



Sign in to add a comment

all apps launcher page for new launcher

Project Member Reported by newcomer@chromium.org, Jun 21 2017

Issue description

Add 5th row to all apps page.
Vertically center the all apps page.

Not required for dogfood.
 
Blocking: 735709

Comment 2 by warx@chromium.org, Jun 21 2017

Cc: -warx@chromium.org newcomer@chromium.org
Owner: warx@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1948539699b040fc84719d100788d393260efe95

commit 1948539699b040fc84719d100788d393260efe95
Author: warx <warx@chromium.org>
Date: Thu Jun 22 23:35:10 2017

cros: update app list item view for all apps grid view

Changes:
(1) app list item view, which is used for all apps grid view, has the
same tile layout (icon, title, and their paddings) requirement as start
page recommended apps tile.
(2) fix recommended apps tile title width issue: it has 80px width
requirement, we just need to set left and right 8px insets for it.

R=xiyuan@chromium.org
CC=newcomer@chromium.org, weidongg@chromium.org
BUG= 735702 
TEST=tested with and without --enable-features=EnableFullscreenAppList
flag

Review-Url: https://codereview.chromium.org/2945343003
Cr-Commit-Position: refs/heads/master@{#481720}

[modify] https://crrev.com/1948539699b040fc84719d100788d393260efe95/ui/app_list/app_list_constants.cc
[modify] https://crrev.com/1948539699b040fc84719d100788d393260efe95/ui/app_list/app_list_constants.h
[modify] https://crrev.com/1948539699b040fc84719d100788d393260efe95/ui/app_list/views/app_list_item_view.cc
[modify] https://crrev.com/1948539699b040fc84719d100788d393260efe95/ui/app_list/views/app_list_item_view.h
[modify] https://crrev.com/1948539699b040fc84719d100788d393260efe95/ui/app_list/views/search_result_tile_item_view.cc

Comment 4 by warx@chromium.org, Jun 26 2017

Blockedon: 736791

Comment 5 by warx@chromium.org, Jun 27 2017

Labels: NewLauncherUIV1
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc6f4ff899528aeb24316593094644c2b00e1178

commit fc6f4ff899528aeb24316593094644c2b00e1178
Author: Qiang Xu <warx@chromium.org>
Date: Wed Jun 28 22:12:22 2017

cros: all apps page #02 UI specifications

changes:
This CL is mainly dealing with the UI layout of all apps page #02 and
all subsequent pages.
(1) 5 rows 5 cols
(2) search box: 24px top padding, 21px bottom padding, fixed width (no
longer in line with apps grid view's width.
(3) add all apps indicator chip, 8px bottom padding with apps grid.
(4) apps grid: 24px horizontal padding, 12px vertical padding.
(5) page switcher view: remove 24px padding for its width.

UI specification: https://screenshot.googleplex.com/0A4VEH19ukJ
WIP screenshot: https://screenshot.googleplex.com/hmWYqP99kPJ

TODO: page switcher view layout.

flag, attached screenshot.

R: xiyuan@chromium.org
Bug:  735702 ,  735709 
TEST: tested with and without --enable-features=EnableFullscreenAppList
Change-Id: I26b065f40e9e0f5338a64b04926e8c52b90da16d
Reviewed-on: https://chromium-review.googlesource.com/551484
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483166}
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/app_list_constants.cc
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/app_list_constants.h
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/apps_container_view.cc
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/apps_container_view.h
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/contents_view.cc
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/contents_view.h
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/page_switcher_vertical.cc
[modify] https://crrev.com/fc6f4ff899528aeb24316593094644c2b00e1178/ui/app_list/views/start_page_view.cc

Comment 7 by warx@chromium.org, Jul 6 2017

Cc: warx@chromium.org
 Issue 735709  has been merged into this issue.

Comment 8 by warx@chromium.org, Jul 6 2017

EstimatedDays: ----
Summary: all apps launcher page for new launcher (was: Add 5th row to all apps page and vertically center all apps page)
specs: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZY5BZ8F2qhKy/files/MCGAAf1s-t7xY9qCCrLpNXqWwMSJbxAVNpw, page 4.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef729e4eb35d8d7096dfaf8b945074595fadd71f

commit ef729e4eb35d8d7096dfaf8b945074595fadd71f
Author: Qiang Xu <warx@chromium.org>
Date: Fri Jul 07 23:56:28 2017

cros: extract AppsGridView::CalculateTransitionOffset method

changes:
Extracting a private method CalculateTransitionOffset for a view's
current page. For new launcher, not only the all apps tiles, but also
the new added views (indicators, suggested apps) should have transition
offset.

Change-Id: I8b65332f06ea7aea107b9b77081d8dbdf54c47d7
Bug:  735702 
TEST: no functional/UI change
Reviewed-on: https://chromium-review.googlesource.com/562589
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485106}
[modify] https://crrev.com/ef729e4eb35d8d7096dfaf8b945074595fadd71f/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/ef729e4eb35d8d7096dfaf8b945074595fadd71f/ui/app_list/views/apps_grid_view.h

Comment 10 by warx@chromium.org, Jul 10 2017

Blockedon: 740321
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bb07b62b32185b1757051c0cd4f12c7a60a2cd9

commit 0bb07b62b32185b1757051c0cd4f12c7a60a2cd9
Author: Qiang Xu <warx@chromium.org>
Date: Thu Jul 13 00:38:38 2017

app_list: add suggested apps to all apps launcher page

changes:
(1) refactor AppsGridView's ctor to accept ContentsView*.
(2) move all apps indicator from AppsContainerView to AppsGridView.
(3) host suggested_apps_indicator_, all_apps_indicator_, and
suggestions container view in AppsGridView.
(4) for all apps layout, the first page is 4*5 and all others are 5*5.
(5) update keyboard arrow moving focus for new launcher. See focus
rules in inline comments.
(6) refactor AppsGridViewTest by creating app_list_view_ to test
AppsGridView, also make it parameterized tests to test
EnableFullscreenAppList. Most of the tests are opened for both old
and new launcher.
(7) add tests: CreatePage, HandleSuggestionsMove, 
MoveSelectedOnAllAppsTiles.

UI specification: https://screenshot.googleplex.com/ebJ2ug1xS9Z.

flag, screenshot: https://screenshot.googleplex.com/AbpxexGtKNj
keyboard moving focus works as expected.
also added test coverage.

Bug:  735702 
TEST: tested with and without --enable-features=EnableFullscreenAppList
Change-Id: I7fe602c84bdeb8f659013de76285fb2dca9f6ec3
Reviewed-on: https://chromium-review.googlesource.com/564485
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486186}
[modify] https://crrev.com/0bb07b62b32185b1757051c0cd4f12c7a60a2cd9/ui/app_list/views/app_list_folder_view.cc
[modify] https://crrev.com/0bb07b62b32185b1757051c0cd4f12c7a60a2cd9/ui/app_list/views/app_list_main_view.h
[modify] https://crrev.com/0bb07b62b32185b1757051c0cd4f12c7a60a2cd9/ui/app_list/views/apps_container_view.cc
[modify] https://crrev.com/0bb07b62b32185b1757051c0cd4f12c7a60a2cd9/ui/app_list/views/apps_container_view.h
[modify] https://crrev.com/0bb07b62b32185b1757051c0cd4f12c7a60a2cd9/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/0bb07b62b32185b1757051c0cd4f12c7a60a2cd9/ui/app_list/views/apps_grid_view.h
[modify] https://crrev.com/0bb07b62b32185b1757051c0cd4f12c7a60a2cd9/ui/app_list/views/apps_grid_view_unittest.cc
[modify] https://crrev.com/0bb07b62b32185b1757051c0cd4f12c7a60a2cd9/ui/app_list/views/test/apps_grid_view_test_api.cc
[modify] https://crrev.com/0bb07b62b32185b1757051c0cd4f12c7a60a2cd9/ui/app_list/views/test/apps_grid_view_test_api.h

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/350482bd11b424bc1252e8c55d479f3fd69dcfbd

commit 350482bd11b424bc1252e8c55d479f3fd69dcfbd
Author: Qiang Xu <warx@chromium.org>
Date: Fri Jul 14 00:57:16 2017

app_list: enable more AppsGridViewTests for fullscreen app list

changes:
For fullscreen app list:
(1) Fix on the first all apps page, cannot drag to group apps into
folder. Fix is in AppsGridView::GetNearestTileIndexForPoint().
(2) enable more AppsGridViewTests because of (1).

Bug:  735702 
TEST: covered by tests
Change-Id: I8a10cc68dd9564ebd9f8df676046b750254facfe
Reviewed-on: https://chromium-review.googlesource.com/567634
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486561}
[modify] https://crrev.com/350482bd11b424bc1252e8c55d479f3fd69dcfbd/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/350482bd11b424bc1252e8c55d479f3fd69dcfbd/ui/app_list/views/apps_grid_view_unittest.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/290d0a12119fcf23eec5aafeb2a3c509061f9703

commit 290d0a12119fcf23eec5aafeb2a3c509061f9703
Author: Qiang Xu <warx@chromium.org>
Date: Fri Jul 14 01:10:49 2017

app_list: remove AppsGridViewDelegate

changes:
after go/croscl/564485, AppsGridViewDelegate is no longer needed, remove
it in this CL.

Bug:  735702 
TEST: still compiles
Change-Id: I8aca563c6951283157121981bebd53b39d5ab05e
Reviewed-on: https://chromium-review.googlesource.com/571058
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486582}
[modify] https://crrev.com/290d0a12119fcf23eec5aafeb2a3c509061f9703/ui/app_list/BUILD.gn
[modify] https://crrev.com/290d0a12119fcf23eec5aafeb2a3c509061f9703/ui/app_list/views/app_list_main_view.h
[modify] https://crrev.com/290d0a12119fcf23eec5aafeb2a3c509061f9703/ui/app_list/views/apps_grid_view.cc
[delete] https://crrev.com/d558a3f421e835a6037d51b800aa3bdb92a2c8e1/ui/app_list/views/apps_grid_view_delegate.h

Comment 14 by warx@chromium.org, Jul 14 2017

Status: Fixed (was: Assigned)
close this.
Using other bugs to track if bug rises.

Comment 15 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment