Site specific cbuildbot is unused, delete the code! |
||||||
Issue description--config_repo is unused. We should: A) Add an assert to prove it's unused. B) Start deleting/simplifying code to remove support. a) Remove support in top level cbuildbot from bootstrap flow. b) Remove config_lib support, especially site parameters. http://cs/chromeos_public/chromite/lib/config_lib.py?l=985&rcl=0d1321d2833cbf1dd866426427f849a3ca7198a5
,
Jun 21 2017
,
Jun 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/58e85e00ddd174dfd0fbfb87ea2233c3ea252e90 commit 58e85e00ddd174dfd0fbfb87ea2233c3ea252e90 Author: Don Garrett <dgarrett@google.com> Date: Fri Jun 23 23:10:07 2017 cbuildbot: Deprecate --config_repo. Add an assert if --config_repo is used. We believe there are no users left, this is to prove that is true with a small (easily reverted) CL. After this assert soaks for a while, we will finish the removal of a unneeded code in bigger followup CLs. BUG=chromium:735696 TEST=Unittests Change-Id: I580fc835fe4976c4d7cca094249752f435b2a1c2 Reviewed-on: https://chromium-review.googlesource.com/544116 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/58e85e00ddd174dfd0fbfb87ea2233c3ea252e90/scripts/cbuildbot.py [modify] https://crrev.com/58e85e00ddd174dfd0fbfb87ea2233c3ea252e90/scripts/cbuildbot_unittest.py
,
Aug 3 2017
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/4d4ebf1aabe891acbfbdcff3a2b13d78fb7472d9 commit 4d4ebf1aabe891acbfbdcff3a2b13d78fb7472d9 Author: Don Garrett <dgarrett@google.com> Date: Fri Sep 15 03:14:08 2017 cbuildbot: Remove --config-repo option. Site specific support is no longer needed in cbuildbot, this removes the command line option, and sync code needed to support it. We still need to remove support from config_lib and builder class loading. BUG=chromium:735696 TEST=run_tests -q Change-Id: I7a89d08851e413599210955e5385b6031aaf8721 Reviewed-on: https://chromium-review.googlesource.com/653729 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/4d4ebf1aabe891acbfbdcff3a2b13d78fb7472d9/scripts/cbuildbot.py [modify] https://crrev.com/4d4ebf1aabe891acbfbdcff3a2b13d78fb7472d9/cbuildbot/stages/sync_stages_unittest.py [modify] https://crrev.com/4d4ebf1aabe891acbfbdcff3a2b13d78fb7472d9/cbuildbot/stages/sync_stages.py
,
Mar 30 2018
,
Mar 30 2018
,
Apr 5 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dgarr...@chromium.org
, Jun 21 2017Owner: dgarr...@chromium.org