Missing *all_notification_text_2 resources in Android |
||
Issue descriptionBuilders failing: - https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builder%20%28dbg%29/builds/19579 - https://build.chromium.org/p/chromium.android/builders/Android%20MIPS%20Builder%20%28dbg%29/builds/9688 This looks like it's due to https://chromium-review.googlesource.com/c/541059/ (see this line [1]) [1] https://cs.chromium.org/chromium/src/chrome/app/generated_resources.grd?type=cs&q=%22message+name%3D%22+%22IDS_VIDEO_CALL_NOTIFICATION_TEXT_2%22&l=12327 Assigning to Biao until this is reverted.
,
Jun 21 2017
For debugging convenience, here are the compile errors:
---
../../chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java:377: warning: [deprecation] setBackgroundDrawable(Drawable) in View has been deprecated
public void setBackgroundDrawable(Drawable background) {
^
../../chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java:381: warning: [deprecation] setBackgroundDrawable(Drawable) in View has been deprecated
super.setBackgroundDrawable(background);
^
../../chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManager.java:357: warning: [deprecation] setBackgroundDrawable(Drawable) in View has been deprecated
mTranslucent.surfaceView.setBackgroundDrawable(background);
^
../../chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManager.java:358: warning: [deprecation] setBackgroundDrawable(Drawable) in View has been deprecated
mOpaque.surfaceView.setBackgroundDrawable(background);
^
../../chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SpacingItem.java:52: warning: [deprecation] notifyItemChanged(int) in ChildNode has been deprecated
notifyItemChanged(0);
^
../../chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java:222: error: cannot find symbol
notificationContentTextId = R.string.video_audio_call_notification_text_2;
^
symbol: variable video_audio_call_notification_text_2
location: class string
../../chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java:224: error: cannot find symbol
notificationContentTextId = R.string.video_call_notification_text_2;
^
symbol: variable video_call_notification_text_2
location: class string
../../chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java:226: error: cannot find symbol
notificationContentTextId = R.string.audio_call_notification_text_2;
^
symbol: variable audio_call_notification_text_2
location: class string
3 errors
---
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a37fea5ad09525282146f647c6df9b35514511c commit 0a37fea5ad09525282146f647c6df9b35514511c Author: bshe <bshe@chromium.org> Date: Thu Jun 22 15:52:12 2017 Reland "Show a toast when presenting WebVR in VR browser" It was reverted here: https://chromium-review.googlesource.com/c/543908 due to failure on mips bot. This CL make the missing strings available again for android bots. This is a reland of abfcb1b11521597250bf805e6ccd99c43b78cc9d Original change's description: > Show a toast when presenting WebVR in VR browser > > Bug: 733015 > Change-Id: I4d88dabc7201fa0b58b89aeafb604ca4025ad7a2 > Reviewed-on: https://chromium-review.googlesource.com/541059 > Commit-Queue: Biao She <bshe@chromium.org> > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481286} Bug: 733015, 735676 Change-Id: I0d98d2202233b5107cdb4168541a82f3e4a5185e Reviewed-on: https://chromium-review.googlesource.com/545055 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#481545} [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/app/generated_resources.grd [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/BUILD.gn [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/color_scheme.cc [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/color_scheme.h [add] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/textures/presentation_toast_texture.cc [add] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/textures/presentation_toast_texture.h [add] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/ui_elements/presentation_toast.cc [add] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/ui_elements/presentation_toast.h [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/ui_elements/ui_element_debug_id.h [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/ui_interface.h [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/ui_scene_manager.cc [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/ui_scene_manager.h [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/vr_gl_thread.cc [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/vr_gl_thread.h [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/0a37fea5ad09525282146f647c6df9b35514511c/chrome/browser/android/vr_shell/vr_shell.h
,
Jun 26 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by ntfschr@chromium.org
, Jun 21 2017