New issue
Advanced search Search tips

Issue 735666 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.2%-19.6% regression in system_health.memory_mobile at 480380:480528

Project Member Reported by lanwei@chromium.org, Jun 21 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 21 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/browse_social/browse_social_instagram

Revision             Result                      N
chromium@480379      182722219 +- 78981687       21      good
chromium@480528      165486487 +- 149808241      21      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.instagram system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976141451213456624

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6068476092874752


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jun 22 2017


=== BISECT JOB RESULTS ===
Perf regression found but unable to continue

Bisect was stopped because a commit couldn't be classified as either
good or bad.


Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/browse_social/browse_social_instagram

Revision             Result                      N
chromium@480379      187119618 +- 85817254       21      good
chromium@480454      165749143 +- 130887819      21      unknown
chromium@480528      159496543 +- 144542879      21      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.instagram system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976132343072380080

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6068476092874752


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
 Issue 735664  has been merged into this issue.
 Issue 735665  has been merged into this issue.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Aug 17 2017

Cc: fdoray@chromium.org
Owner: fdoray@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author fdoray@chromium.org ===

Hi fdoray@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Francois Doray
  Commit : 6d3c6496933a57ef2aeebc9772bb1d3e18fec352
  Date   : Mon Jun 19 15:54:37 2017
  Subject: Increase number of foreground threads in --single-process browser process.

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:malloc:effective_size_avg/browse_media/browse_media_imgur
  Change       : 6.07% | 37155213.3333 -> 39409088.0

Revision             Result                   N
chromium@480427      37155213 +- 710443       6      good
chromium@480444      37305687 +- 304454       6      good
chromium@480453      37187119 +- 734172       6      good
chromium@480454      39150540 +- 1198242      6      bad       <--
chromium@480455      39043952 +- 1031743      6      bad
chromium@480457      38816371 +- 1179251      6      bad
chromium@480461      39409088 +- 739299       6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.imgur system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8970982780065449456


For feedback, file a bug with component Speed>Bisection
fdoray: any update on this?
It is not unexpected that increasing the number of threads in a process increases memory consumption. Increasing the number of threads was required to fix performance issues  https://crbug.com/727573 

We already plan to assess the impact of changing the number of threads on memory consumption and performance via a field trial.

Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, Sep 27 2017


=== Auto-CCing suspected CL author fdoray@chromium.org ===

Hi fdoray@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Francois Doray
  Commit : 6d3c6496933a57ef2aeebc9772bb1d3e18fec352
  Date   : Mon Jun 19 15:54:37 2017
  Subject: Increase number of foreground threads in --single-process browser process.

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:malloc:effective_size_avg/browse_news/browse_news_cnn
  Change       : 6.07% | 45694757.0 -> 48469765.0

Revision             Result                   N
chromium@480427      45694757 +- 1019336      6      good
chromium@480444      45403834 +- 1551931      6      good
chromium@480453      45345481 +- 1327334      6      good
chromium@480454      48006468 +- 1411603      6      bad       <--
chromium@480455      47731560 +- 1503602      6      bad
chromium@480457      47974987 +- 1634914      6      bad
chromium@480461      48469765 +- 1518335      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.cnn system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8967274957247480544


For feedback, file a bug with component Speed>Bisection
Status: WontFix (was: Assigned)
WontFix-ing per #13 and since this doesn't seem to have come up in the release process for M61.

Sign in to add a comment