New issue
Advanced search Search tips

Issue 735660 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Pin keyboard backspace arrow highlight is off-center

Project Member Reported by jdufault@chromium.org, Jun 21 2017

Issue description

Pin keyboard backspace arrow highlight is off-center

Hold down the backspace key and the material ripple is not centered on the backspace arrow.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa06a1a07bfcbdb3b1b1448d376c4d1148cedde2

commit fa06a1a07bfcbdb3b1b1448d376c4d1148cedde2
Author: wzang <wzang@chromium.org>
Date: Tue Jun 27 01:32:34 2017

Signin screen polish in response to UI review

The changes here have been shown and confirmed by UX so they will stay
unless there's specs update.

(1) Add an icon beside 'App' in the header bar. Currently'App' is the
only item without an icon.

(2) For  crbug.com/735660 , the ripple shape is changed to round but it's
still slightly off the center. I need to contact with UX for a new .svg.

(3) Add animation for public session pod expansion and user drop down menu.

(4) Other minor style changes. If interested please reference the QA here:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZV-kBQWRQPoA/files/MCHtA7U1iMGr6zkLgIS_GHBTJhNtoz9Axs8

BUG= 718159 ,  735660 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2947213003
Cr-Commit-Position: refs/heads/master@{#482503}

[add] https://crrev.com/fa06a1a07bfcbdb3b1b1448d376c4d1148cedde2/chrome/browser/resources/chromeos/login/images/1x/show-apps.svg
[add] https://crrev.com/fa06a1a07bfcbdb3b1b1448d376c4d1148cedde2/chrome/browser/resources/chromeos/login/images/2x/show-apps.svg
[modify] https://crrev.com/fa06a1a07bfcbdb3b1b1448d376c4d1148cedde2/chrome/browser/resources/chromeos/login/md_header_bar.css
[modify] https://crrev.com/fa06a1a07bfcbdb3b1b1448d376c4d1148cedde2/chrome/browser/resources/chromeos/login/md_header_bar.html
[modify] https://crrev.com/fa06a1a07bfcbdb3b1b1448d376c4d1148cedde2/ui/login/account_picker/md_screen_account_picker.css
[modify] https://crrev.com/fa06a1a07bfcbdb3b1b1448d376c4d1148cedde2/ui/login/account_picker/md_user_pod_row.css
[modify] https://crrev.com/fa06a1a07bfcbdb3b1b1448d376c4d1148cedde2/ui/login/account_picker/md_user_pod_row.js
[modify] https://crrev.com/fa06a1a07bfcbdb3b1b1448d376c4d1148cedde2/ui/login/account_picker/md_user_pod_template.html

Comment 2 by wzang@chromium.org, Jul 24 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment