rename SSHHost run() to run_very_slowly() |
|
Issue descriptionhost.run() is very slow as currently used via ssh master connection (up to 350ms with 40ms lower bound due to DUT overhead, see issue 726481 and issue 734887). We should change autotest to not use ssh RPC whenever possible. Hidehiko is working on this. But we also need to discourage people adding more calls not understanding that they are very costly. Renaming from "run" to "run_very_slowly" will be a large change (might be broken into multiple pieces using a wrapper to avoid rebase issues). Also, please put some spew into run to indicate the caller of the stack so it can be eliminated (for the server log files, we already do this for client /var/log/messages files).
,
Jun 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5e521523a6b7c5890f1c0a53ebdec80b6af1973d commit 5e521523a6b7c5890f1c0a53ebdec80b6af1973d Author: Ilja H. Friedel <ihf@chromium.org> Date: Sat Jun 24 00:46:55 2017 autotest: spew less ssh warnings. BUG=chromium:735653 TEST=Ran locally. Change-Id: I2a434782b9b7ed7a3d31289d9925f3c8502a6d9f Reviewed-on: https://chromium-review.googlesource.com/546998 Commit-Queue: Ilja H. Friedel <ihf@chromium.org> Tested-by: Ilja H. Friedel <ihf@chromium.org> Reviewed-by: Po-Hsien Wang <pwang@chromium.org> [modify] https://crrev.com/5e521523a6b7c5890f1c0a53ebdec80b6af1973d/server/hosts/ssh_host.py
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ad719c19df78d5e28ebb760d87ff1ac08cb0e45d commit ad719c19df78d5e28ebb760d87ff1ac08cb0e45d Author: Allen Li <ayatane@chromium.org> Date: Tue Jun 27 23:54:26 2017 Revert "Rename SSHHost.run to SSHHost.run_very_slowly" This reverts commit 672fb5f8806694d9476f016c0f1094da29120f31. Reason for revert: Broke android tests: crbug.com/737316 Original change's description: > Rename SSHHost.run to SSHHost.run_very_slowly > > This CL renames several places that calls SSHHost.run directly to SSHHost.run_very_slowly. > In addition, it warns the caller with a more verbose server stack message now. > > BUG=chromium:735653 > TEST=test_that dut graphics_Sanity > ./utils/unittest_suite.py --debug > CQ-DEPEND=I2a434782b9b7ed7a3d31289d9925f3c8502a6d9f > > Change-Id: Icd22fe9bcc4b5a47320478932194a8b535f4a936 > Reviewed-on: https://chromium-review.googlesource.com/545116 > Commit-Ready: Po-Hsien Wang <pwang@chromium.org> > Tested-by: Po-Hsien Wang <pwang@chromium.org> > Reviewed-by: Ilja H. Friedel <ihf@chromium.org> Bug: chromium:735653 Change-Id: If57cd6103d73bc1f0335866d8c130953754df0d9 Reviewed-on: https://chromium-review.googlesource.com/550970 Reviewed-by: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Trybot-Ready: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/ad719c19df78d5e28ebb760d87ff1ac08cb0e45d/server/hosts/abstract_ssh.py [modify] https://crrev.com/ad719c19df78d5e28ebb760d87ff1ac08cb0e45d/server/control_segments/get_network_stats [modify] https://crrev.com/ad719c19df78d5e28ebb760d87ff1ac08cb0e45d/client/common_lib/hosts/base_classes.py [modify] https://crrev.com/ad719c19df78d5e28ebb760d87ff1ac08cb0e45d/server/autotest_unittest.py [modify] https://crrev.com/ad719c19df78d5e28ebb760d87ff1ac08cb0e45d/server/hosts/ssh_host.py [modify] https://crrev.com/ad719c19df78d5e28ebb760d87ff1ac08cb0e45d/server/hosts/remote.py [modify] https://crrev.com/ad719c19df78d5e28ebb760d87ff1ac08cb0e45d/server/hosts/cros_host.py [modify] https://crrev.com/ad719c19df78d5e28ebb760d87ff1ac08cb0e45d/server/autotest.py [modify] https://crrev.com/ad719c19df78d5e28ebb760d87ff1ac08cb0e45d/server/site_autotest.py [modify] https://crrev.com/ad719c19df78d5e28ebb760d87ff1ac08cb0e45d/client/common_lib/cros/path_utils.py [modify] https://crrev.com/ad719c19df78d5e28ebb760d87ff1ac08cb0e45d/client/bin/result_tools/runner.py
,
Jun 8 2018
Hi, this bug has not been updated recently. Please acknowledge the bug and provide status within two weeks (6/22/2018), or the bug will be closed. Thank you. |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Jun 22 2017