Issue metadata
Sign in to add a comment
|
Regression caused by "Allow a minimum semi-space size of 512K." |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 21 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8976143062885404784
,
Jun 22 2017
=== Auto-CCing suspected CL author hpayer@chromium.org === Hi hpayer@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : hpayer Commit : 0d2ed6c3287ec48ee06ec1b69287ed4bf0dd60d7 Date : Mon Jun 19 10:16:13 2017 Subject: [heap] Allow a minimum semi-space size of 512K. Bisect Details Configuration: android_webview_arm64_aosp_perf_bisect Benchmark : system_health.memory_mobile Metric : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/load_games/load_games_lazors Change : 11.37% | 3113738.66667 -> 3467800.0 Revision Result N chromium@480809 3113739 +- 405755 9 good chromium@480821 3064469 +- 7945.63 6 good chromium@480821,v8@8a32788f39 3070960 +- 0.0 6 good chromium@480821,v8@f626d5df7e 3070960 +- 0.0 6 good chromium@480821,v8@bc717ae84b 3070960 +- 0.0 6 good chromium@480821,v8@0d2ed6c328 3468408 +- 498.831 6 bad <-- chromium@480821,v8@d6c9e534c8 3468336 +- 394.36 6 bad chromium@480821,v8@2325ef535f 3471440 +- 498.831 6 bad chromium@480822 3467649 +- 818.226 6 bad chromium@480823 3467656 +- 498.831 6 bad chromium@480824 3467800 +- 498.831 6 bad chromium@480827 3467577 +- 403.253 6 bad chromium@480832 3467872 +- 394.36 6 bad chromium@480855 3467800 +- 498.831 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.games.lazors system_health.memory_mobile Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8976143062885404784 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=6737309606608896 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 22 2017
,
Jun 23 2017
,
Jun 26 2017
Ulan will make the call...
,
Jun 27 2017
,
Jun 28 2017
,
Jun 28 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8975545458956050304
,
Jun 28 2017
A revert of the CL is ready: https://chromium-review.googlesource.com/c/552541/ I will wait until crbug.com/737353 resolved before landing the revert to ensure that the graphs recover with the revert.
,
Jun 28 2017
Issue 737496 has been merged into this issue.
,
Jun 28 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Sunny Sachanandani Commit : f9a0da96d26ec1fe2121a8eef62f7bd7e9330555 Date : Tue Jun 13 22:16:40 2017 Subject: Enable gpu scheduler on waterfall and developer builds. Bisect Details Configuration: android_nexus7_perf_bisect Benchmark : system_health.memory_mobile Metric : memory:chrome:all_processes:reported_by_chrome:gpu:effective_size_avg/load_news/load_news_irctc Change : 11.98% | 4545819.55556 -> 5090245.33333 Revision Result N chromium@477935 4545820 +- 863355 9 good chromium@478763 4391992 +- 0.0 6 good chromium@478970 4396392 +- 24099.8 6 good chromium@479074 4391992 +- 0.0 6 good chromium@479126 4391992 +- 0.0 6 good chromium@479152 4396485 +- 24611.0 6 good chromium@479165 4391992 +- 0.0 6 good chromium@479171 4391992 +- 0.0 6 good chromium@479174 4391992 +- 0.0 6 good chromium@479175 5078072 +- 33652.1 6 bad <-- chromium@479176 5096379 +- 30935.2 6 bad chromium@479177 5082552 +- 45440.9 6 bad chromium@479591 5090438 +- 52797.3 9 bad chromium@481246 5090245 +- 64138.9 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.irctc system_health.memory_mobile Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8975545458956050304 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=4512543189499904 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 30 2017
Comment #12 shows that the GPU regressions come from issue 733705. But other regressions are unrelated.
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/f341bb0f623821e56349735e47e1a9094f65d9a3 commit f341bb0f623821e56349735e47e1a9094f65d9a3 Author: Ulan Degenbaev <ulan@chromium.org> Date: Fri Jun 30 12:03:04 2017 Revert "[heap] Allow a minimum semi-space size of 512K." This reverts commit 0d2ed6c3287ec48ee06ec1b69287ed4bf0dd60d7. The CL introduced perf regressions: crbug.com/735649 . We are going to reland the CL in an isolated V8 roll to ensure that perf regressions are attributed correctly. Original commit message: > [heap] Allow a minimum semi-space size of 512K. > This CL also reduces the minimum semi-space size to 512K. > BUG=chromium:716032 BUG= chromium:735649 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I1f1b08ca6853347c00070f000c309d839ff8a4bb Reviewed-on: https://chromium-review.googlesource.com/552541 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#46349} [modify] https://crrev.com/f341bb0f623821e56349735e47e1a9094f65d9a3/include/v8.h [modify] https://crrev.com/f341bb0f623821e56349735e47e1a9094f65d9a3/src/api.cc [modify] https://crrev.com/f341bb0f623821e56349735e47e1a9094f65d9a3/src/heap/heap.cc [modify] https://crrev.com/f341bb0f623821e56349735e47e1a9094f65d9a3/src/heap/heap.h [modify] https://crrev.com/f341bb0f623821e56349735e47e1a9094f65d9a3/test/cctest/heap/test-heap.cc [modify] https://crrev.com/f341bb0f623821e56349735e47e1a9094f65d9a3/test/cctest/test-api.cc [modify] https://crrev.com/f341bb0f623821e56349735e47e1a9094f65d9a3/test/cctest/test-strings.cc [modify] https://crrev.com/f341bb0f623821e56349735e47e1a9094f65d9a3/test/unittests/heap/heap-unittest.cc
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/bb29f9a4d6fb5e3277aa5b58bc532cd90f687f0c commit bb29f9a4d6fb5e3277aa5b58bc532cd90f687f0c Author: Ulan Degenbaev <ulan@chromium.org> Date: Wed Jul 19 12:53:27 2017 [heap] Add API to set heap semi-space limits in KB. This relands parts of "[heap] Allow a minimum semi-space size of 512K." excluding the actual semi-space size change. This partially reverts commit f341bb0f623821e56349735e47e1a9094f65d9a3 > Original commit message: > Revert "[heap] Allow a minimum semi-space size of 512K." > This reverts commit 0d2ed6c3287ec48ee06ec1b69287ed4bf0dd60d7. > The CL introduced perf regressions: crbug.com/735649 . > We are going to reland the CL in an isolated V8 roll to ensure > that perf regressions are attributed correctly. > Original commit message: > > [heap] Allow a minimum semi-space size of 512K. > > This CL also reduces the minimum semi-space size to 512K. > > BUG=chromium:716032 > BUG= chromium:735649 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I5ed66b72104aa877d67fcd20bdadc807ea1551c3 Reviewed-on: https://chromium-review.googlesource.com/575065 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#46762} [modify] https://crrev.com/bb29f9a4d6fb5e3277aa5b58bc532cd90f687f0c/include/v8.h [modify] https://crrev.com/bb29f9a4d6fb5e3277aa5b58bc532cd90f687f0c/src/api.cc [modify] https://crrev.com/bb29f9a4d6fb5e3277aa5b58bc532cd90f687f0c/src/heap/heap.cc [modify] https://crrev.com/bb29f9a4d6fb5e3277aa5b58bc532cd90f687f0c/src/heap/heap.h [modify] https://crrev.com/bb29f9a4d6fb5e3277aa5b58bc532cd90f687f0c/test/cctest/heap/test-heap.cc [modify] https://crrev.com/bb29f9a4d6fb5e3277aa5b58bc532cd90f687f0c/test/cctest/test-api.cc [modify] https://crrev.com/bb29f9a4d6fb5e3277aa5b58bc532cd90f687f0c/test/cctest/test-strings.cc [modify] https://crrev.com/bb29f9a4d6fb5e3277aa5b58bc532cd90f687f0c/test/unittests/heap/heap-unittest.cc
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/176a2b24fb23a0c9a3bc9eec27f6445dbfa5ab27 commit 176a2b24fb23a0c9a3bc9eec27f6445dbfa5ab27 Author: Ulan Degenbaev <ulan@chromium.org> Date: Wed Jul 19 13:04:47 2017 [heap] Reland "[heap] Allow a minimum semi-space size of 512K." This patch changes the semi-space size to 512K. > Original commit message: > Revert "[heap] Allow a minimum semi-space size of 512K." > This reverts commit 0d2ed6c3287ec48ee06ec1b69287ed4bf0dd60d7. > The CL introduced perf regressions: crbug.com/735649 . > We are going to reland the CL in an isolated V8 roll to ensure > that perf regressions are attributed correctly. > Original commit message: > > [heap] Allow a minimum semi-space size of 512K. > > This CL also reduces the minimum semi-space size to 512K. > > BUG=chromium:716032 > BUG= chromium:735649 Change-Id: Iabc377cba2911b28d51b98bb5b85134d4e893632 Reviewed-on: https://chromium-review.googlesource.com/575066 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#46763} [modify] https://crrev.com/176a2b24fb23a0c9a3bc9eec27f6445dbfa5ab27/src/heap/heap.cc [modify] https://crrev.com/176a2b24fb23a0c9a3bc9eec27f6445dbfa5ab27/src/heap/heap.h [modify] https://crrev.com/176a2b24fb23a0c9a3bc9eec27f6445dbfa5ab27/test/unittests/heap/heap-unittest.cc
,
Jul 24 2017
,
Jul 25 2017
,
Jul 25 2017
Impact around the original CL: https://chromeperf.appspot.com/group_report?rev=480821 Impact around the reland CL: https://chromeperf.appspot.com/group_report?rev=488745 Memory usage improves on small webpages by ~10% (~500K). Total scavenger time increases by 20%-60%.
,
Jul 25 2017
https://chromeperf.appspot.com/report?sid=ae8540f4469ca2b274c92f97448e8e30f0a463b114ebd79c3d367890337666db&start_rev=1498217873&end_rev=1500973533 These two graphs improved significantly when introduced the smaller page sizes. It looks like at least clank also improves by ~1.5% on effective size for the roll containing the reland.
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/774a4c5e240569b551cc9d19ae8cac146891d4c4 commit 774a4c5e240569b551cc9d19ae8cac146891d4c4 Author: Ulan Degenbaev <ulan@chromium.org> Date: Fri Jul 28 19:42:31 2017 Revert "[heap] Reland "[heap] Allow a minimum semi-space size of 512K."" This reverts commit 176a2b24fb23a0c9a3bc9eec27f6445dbfa5ab27. Reason for revert: performance regression on the benchmarks. Original change's description: > [heap] Reland "[heap] Allow a minimum semi-space size of 512K." > > This patch changes the semi-space size to 512K. > > > Original commit message: > > Revert "[heap] Allow a minimum semi-space size of 512K." > > This reverts commit 0d2ed6c3287ec48ee06ec1b69287ed4bf0dd60d7. > > The CL introduced perf regressions: crbug.com/735649 . > > We are going to reland the CL in an isolated V8 roll to ensure > > that perf regressions are attributed correctly. > > > Original commit message: > > > [heap] Allow a minimum semi-space size of 512K. > > > This CL also reduces the minimum semi-space size to 512K. > > > BUG=chromium:716032 > > BUG= chromium:735649 > > Change-Id: Iabc377cba2911b28d51b98bb5b85134d4e893632 > Reviewed-on: https://chromium-review.googlesource.com/575066 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46763} TBR=ulan@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I80f8b6699f41e91512f7cec38060c829252ff95e Reviewed-on: https://chromium-review.googlesource.com/591309 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#46982} [modify] https://crrev.com/774a4c5e240569b551cc9d19ae8cac146891d4c4/src/heap/heap.cc [modify] https://crrev.com/774a4c5e240569b551cc9d19ae8cac146891d4c4/src/heap/heap.h [modify] https://crrev.com/774a4c5e240569b551cc9d19ae8cac146891d4c4/test/unittests/heap/heap-unittest.cc
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/7486dc3331290ac795162bac7c3c5e3b52573426 commit 7486dc3331290ac795162bac7c3c5e3b52573426 Author: Ulan Degenbaev <ulan@chromium.org> Date: Mon Jul 31 15:45:06 2017 [heap] Partially reland "Allow a minimum semi-space size of 512K." This sets the minimum semi-space size to 512K, but does not change the initial semi-space size. This reverts commit 774a4c5e240569b551cc9d19ae8cac146891d4c4. Original commit message: > [heap] Allow a minimum semi-space size of 512K. > This CL also reduces the minimum semi-space size to 512K. > BUG=chromium:716032 BUG= chromium:735649 TBR=mlippautz@chromium.org Change-Id: I1f5dd05b0851ba2b438bedcc023a5cf5f9242a81 Reviewed-on: https://chromium-review.googlesource.com/594107 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47016} [modify] https://crrev.com/7486dc3331290ac795162bac7c3c5e3b52573426/src/heap/heap.cc [modify] https://crrev.com/7486dc3331290ac795162bac7c3c5e3b52573426/src/heap/heap.h [modify] https://crrev.com/7486dc3331290ac795162bac7c3c5e3b52573426/test/unittests/heap/heap-unittest.cc
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/a5230d81d1f73c383f657a6aaeec32b34d535874 commit a5230d81d1f73c383f657a6aaeec32b34d535874 Author: Ulan Degenbaev <ulan@chromium.org> Date: Wed Aug 02 07:56:10 2017 [heap] Set initial semi-space size to 512K. This is a partial reland of "Allow a minimum semi-space size of 512K." with a heuristic to keep 1MB initial semi-space size for high memory devices. Original commit message: > [heap] Allow a minimum semi-space size of 512K. > This CL also reduces the minimum semi-space size to 512K. > BUG=chromium:716032 BUG= chromium:735649 ,chromium:716032 Change-Id: I5ec851f2380c40dbc34b4576a668f63ae38ac898 Reviewed-on: https://chromium-review.googlesource.com/594387 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#47065} [modify] https://crrev.com/a5230d81d1f73c383f657a6aaeec32b34d535874/src/heap/heap.cc
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/2178bbaf3f2b71093ceb3885e524c076f9d827cd commit 2178bbaf3f2b71093ceb3885e524c076f9d827cd Author: Ulan Degenbaev <ulan@chromium.org> Date: Wed Aug 09 13:06:41 2017 [heap] Adjust upper limit in ComputeMaxSemiSpaceSize. This ensures that 2GB devices get 512K initial semi-space. Bug: chromium:735649 TBR: mlippautz@chromium.org Change-Id: I864c9dfa7cd3ea9040fa56d81d6bf1187c1cf776 Reviewed-on: https://chromium-review.googlesource.com/608129 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47246} [modify] https://crrev.com/2178bbaf3f2b71093ceb3885e524c076f9d827cd/src/heap/heap.h [modify] https://crrev.com/2178bbaf3f2b71093ceb3885e524c076f9d827cd/test/unittests/heap/heap-unittest.cc
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/0089c786ed8825625628f87ac105e01d60559be0 commit 0089c786ed8825625628f87ac105e01d60559be0 Author: Ulan Degenbaev <ulan@chromium.org> Date: Wed Aug 16 10:44:54 2017 Merged: Squashed multiple commits. Merged: [heap] Add API to set heap semi-space limits in KB. Revision: bb29f9a4d6fb5e32 Merged: [heap] Partially reland "Allow a minimum semi-space size of 512K." Revision: 7486dc3331 Merged: [heap] Set initial semi-space size to 512K. Revision: a5230d81d1f73c BUG=chromium:716032, chromium:735649 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=hablich@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ia9946e28ce41dee6199fac571274aa196576385b Reviewed-on: https://chromium-review.googlesource.com/616283 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/branch-heads/6.1@{#47} Cr-Branched-From: 1bf2e10ddb194d4c2871a87a4732613419de892d-refs/heads/6.1.534@{#1} Cr-Branched-From: e825c4318eb2065ffdf9044aa6a5278635c36427-refs/heads/master@{#46746} [modify] https://crrev.com/0089c786ed8825625628f87ac105e01d60559be0/include/v8.h [modify] https://crrev.com/0089c786ed8825625628f87ac105e01d60559be0/src/api.cc [modify] https://crrev.com/0089c786ed8825625628f87ac105e01d60559be0/src/heap/heap.cc [modify] https://crrev.com/0089c786ed8825625628f87ac105e01d60559be0/src/heap/heap.h [modify] https://crrev.com/0089c786ed8825625628f87ac105e01d60559be0/test/cctest/heap/test-heap.cc [modify] https://crrev.com/0089c786ed8825625628f87ac105e01d60559be0/test/cctest/test-api.cc [modify] https://crrev.com/0089c786ed8825625628f87ac105e01d60559be0/test/cctest/test-strings.cc [modify] https://crrev.com/0089c786ed8825625628f87ac105e01d60559be0/test/unittests/heap/heap-unittest.cc
,
Aug 16 2017
,
Aug 16 2017
Issue 747843 has been merged into this issue.
,
Aug 16 2017
Issue 752048 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by lanwei@chromium.org
, Jun 21 2017