Leslie, assigning to you since you worked on this.

IIRC, UX said we weren't supposed to show this text at all, right? It was only supposed to be shown for Cellular networks?

I think in the video posted, a host scan actually wasn't in progress, hence the missing text. We're going to make sure that host scans are always in progress when this UI element is open with  crbug.com/745160 , which should resolve the primary issue of this bug.

If we aren't supposed to be showing this text as Kyle mentioned, then can we agree to change the purpose of this bug to remove this text? Perhaps we should also up the priority of this bug if it can become a UX review blocker.

If Tether TechnologyState is...

UNAVAILABLE or PROHIBITED:
* If Cellular TechnologyState is UNAVAILABLE or PROHIBITED, don't show the "Mobile data" section at all.
* If Cellular TechnologyState is UNINITIALIZED, show the "Mobile data" section with the "Searching for mobile networks" label.
* If Cellular Technology is AVAILABLE, ENABLING, or ENABLED, show the "Mobile data" section with the cellular network and no special label.

UNINITIALIZED:
* If the Tether DeviceState failure reason (see https://codereview.chromium.org/2969493002/) is that Bluetooth is disabled, show the "enable Bluetooth to use Tether" label (see https://codereview.chromium.org/2957043002/).
* Otherwise, Cellular TechnologyState is AVAILABLE and not ENABLED, so the "Mobile data" section should be present, but the toggle should be set to off (with no special label).

AVAILABLE:
* If Cellular TechnologyState is AVAILABLE, ENABLING, or ENABLED, show the "Mobile data" section with the cellular network and no special label.
* Otherwise, the "Mobile data" section should be present, but the toggle should be set to off (with no special label).

ENABLED:
* The available Tether networks (and Cellular network, if applicable) should be shown. If there are no networks available, perhaps we should show a special UI. Asking UX about this.

Note: Tether TechnologyState is never set to ENABLING.

Talked to UX regarding the ENABLED case I mentioned above; there is no special case if there are no networks available. We should just show section without any entries.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2257878a0dfb81bbbc37613752865983568580af

commit 2257878a0dfb81bbbc37613752865983568580af
Author: lesliewatkins <lesliewatkins@chromium.org>
Date: Wed Jul 19 21:03:57 2017

Add a row in the network tray to inform users to turn Bluetooth on to enable Tether.

Renamed TrayDetailsView::InfoLabel to TrayInfoLabel and moved it to its own file. It also now subclasses ActionableView instead of View, so it can be clickable. TrayInfoLabel::Delegate keeps track of whether or not the label is clickable, and handles clicks.

BUG=672263, 735642 

Review-Url: https://codereview.chromium.org/2957043002
Cr-Commit-Position: refs/heads/master@{#487975}

[modify] https://crrev.com/2257878a0dfb81bbbc37613752865983568580af/ash/BUILD.gn
[modify] https://crrev.com/2257878a0dfb81bbbc37613752865983568580af/ash/ash_strings.grd
[modify] https://crrev.com/2257878a0dfb81bbbc37613752865983568580af/ash/system/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/2257878a0dfb81bbbc37613752865983568580af/ash/system/network/network_icon.cc
[modify] https://crrev.com/2257878a0dfb81bbbc37613752865983568580af/ash/system/network/network_list.cc
[modify] https://crrev.com/2257878a0dfb81bbbc37613752865983568580af/ash/system/network/network_list.h
[modify] https://crrev.com/2257878a0dfb81bbbc37613752865983568580af/ash/system/tray/tray_details_view.cc
[modify] https://crrev.com/2257878a0dfb81bbbc37613752865983568580af/ash/system/tray/tray_details_view.h
[add] https://crrev.com/2257878a0dfb81bbbc37613752865983568580af/ash/system/tray/tray_info_label.cc
[add] https://crrev.com/2257878a0dfb81bbbc37613752865983568580af/ash/system/tray/tray_info_label.h
[add] https://crrev.com/2257878a0dfb81bbbc37613752865983568580af/ash/system/tray/tray_info_label_unittest.cc
[modify] https://crrev.com/2257878a0dfb81bbbc37613752865983568580af/ash/system/tray/tray_popup_item_style.cc
[modify] https://crrev.com/2257878a0dfb81bbbc37613752865983568580af/ash/system/tray/tray_popup_item_style.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc8ab64a4bd1d37a7eee1d50629750e79ba6553e

commit fc8ab64a4bd1d37a7eee1d50629750e79ba6553e
Author: sclittle <sclittle@chromium.org>
Date: Wed Jul 19 22:08:54 2017

Revert of Add a row in the network tray to inform users to turn Bluetooth on to enable Tether. (patchset #13 id:240001 of https://codereview.chromium.org/2957043002/ )

Reason for revert:
Broke compile on Linux ChromiumOS Builder (dbg), see https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29

Original issue's description:
> Add a row in the network tray to inform users to turn Bluetooth on to enable Tether.
>
> Renamed TrayDetailsView::InfoLabel to TrayInfoLabel and moved it to its own file. It also now subclasses ActionableView instead of View, so it can be clickable. TrayInfoLabel::Delegate keeps track of whether or not the label is clickable, and handles clicks.
>
> BUG=672263, 735642 
>
> Review-Url: https://codereview.chromium.org/2957043002
> Cr-Commit-Position: refs/heads/master@{#487975}
> Committed: https://chromium.googlesource.com/chromium/src/+/2257878a0dfb81bbbc37613752865983568580af

TBR=khorimoto@chromium.org,jamescook@chromium.org,lesliewatkins@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672263, 735642 

Review-Url: https://codereview.chromium.org/2978363002
Cr-Commit-Position: refs/heads/master@{#488008}

[modify] https://crrev.com/fc8ab64a4bd1d37a7eee1d50629750e79ba6553e/ash/BUILD.gn
[modify] https://crrev.com/fc8ab64a4bd1d37a7eee1d50629750e79ba6553e/ash/ash_strings.grd
[modify] https://crrev.com/fc8ab64a4bd1d37a7eee1d50629750e79ba6553e/ash/system/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/fc8ab64a4bd1d37a7eee1d50629750e79ba6553e/ash/system/network/network_icon.cc
[modify] https://crrev.com/fc8ab64a4bd1d37a7eee1d50629750e79ba6553e/ash/system/network/network_list.cc
[modify] https://crrev.com/fc8ab64a4bd1d37a7eee1d50629750e79ba6553e/ash/system/network/network_list.h
[modify] https://crrev.com/fc8ab64a4bd1d37a7eee1d50629750e79ba6553e/ash/system/tray/tray_details_view.cc
[modify] https://crrev.com/fc8ab64a4bd1d37a7eee1d50629750e79ba6553e/ash/system/tray/tray_details_view.h
[delete] https://crrev.com/19cedfa2f9c3142aaeb19a5da079b8a741d0b080/ash/system/tray/tray_info_label.cc
[delete] https://crrev.com/19cedfa2f9c3142aaeb19a5da079b8a741d0b080/ash/system/tray/tray_info_label.h
[delete] https://crrev.com/19cedfa2f9c3142aaeb19a5da079b8a741d0b080/ash/system/tray/tray_info_label_unittest.cc
[modify] https://crrev.com/fc8ab64a4bd1d37a7eee1d50629750e79ba6553e/ash/system/tray/tray_popup_item_style.cc
[modify] https://crrev.com/fc8ab64a4bd1d37a7eee1d50629750e79ba6553e/ash/system/tray/tray_popup_item_style.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/098beb35d0fabc714992b66a5431dbca376c7c80

commit 098beb35d0fabc714992b66a5431dbca376c7c80
Author: Leslie Watkins <lesliewatkins@chromium.org>
Date: Thu Jul 20 16:20:50 2017

Add a row in the network tray to inform users to turn Bluetooth on to enable Tether.

Rename TrayDetailsView::InfoLabel to TrayInfoLabel and moved it to its own file. It also now subclasses ActionableView instead of View, so it can be clickable. TrayInfoLabel::Delegate keeps track of whether or not the label is clickable, and handles clicks.

Reland of https://codereview.chromium.org/2957043002/

This reverts commit fc8ab64a4bd1d37a7eee1d50629750e79ba6553e.

Bug: 672263,  735642 ,  740671 
Change-Id: I7957bc934e01e226ee588939a21d1fc4afc0bdb3
Reviewed-on: https://chromium-review.googlesource.com/578142
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488263}
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/BUILD.gn
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/ash_strings.grd
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/network/network_icon.cc
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/network/network_list.cc
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/network/network_list.h
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/tray/tray_details_view.cc
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/tray/tray_details_view.h
[add] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/tray/tray_info_label.cc
[add] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/tray/tray_info_label.h
[add] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/tray/tray_info_label_unittest.cc
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/tray/tray_popup_item_style.cc
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/tray/tray_popup_item_style.h

Assigning to hansberry@ who will fix the remaining issues here.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de20d9079e26b7bd05b7ef31ebd1ae97a2de917e

commit de20d9079e26b7bd05b7ef31ebd1ae97a2de917e
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Fri Jul 28 22:43:32 2017

Do not display 'enable Bluetooth' message in system tray network overview.

Bug:  735642 , 672263
Change-Id: I8b208ea48cba94a841f49c2d14c7d5960fb424f6
Reviewed-on: https://chromium-review.googlesource.com/592411
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490528}
[modify] https://crrev.com/de20d9079e26b7bd05b7ef31ebd1ae97a2de917e/ash/system/network/network_icon.cc

This bug requires manual review: There is .grd file changes and we are only 37 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Hi Sheriffs - sorry, the previous commit for this issue was already landed before the M61 branch date. For this merge request, I'm specifically referring to the last commit: de20d9079e26b7bd05b7ef31ebd1ae97a2de917e. This commit doesn't have a .grd change.

Thanks!

Approving merge to M61 Chrome OS.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6744f2e5a5496e7dec1e1f15e49595cedc482328

commit 6744f2e5a5496e7dec1e1f15e49595cedc482328
Author: Kyle Horimoto <khorimoto@google.com>
Date: Mon Jul 31 17:54:18 2017

Do not display 'enable Bluetooth' message in system tray network overview.

TBR=hansberry@chromium.org

(cherry picked from commit de20d9079e26b7bd05b7ef31ebd1ae97a2de917e)

Bug:  735642 , 672263
Change-Id: I8b208ea48cba94a841f49c2d14c7d5960fb424f6
Reviewed-on: https://chromium-review.googlesource.com/592411
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490528}
Reviewed-on: https://chromium-review.googlesource.com/594497
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#160}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/6744f2e5a5496e7dec1e1f15e49595cedc482328/ash/system/network/network_icon.cc