Add a presubmit check to keep OS_IOS defines out of src/chrome/ |
||||
Issue descriptionThe chrome/ directory is not used at all on iOS, but developers who do not know that will add checks for it when they intend to keep code from being built on mobile platforms. In r480991, I removed all the checks, but now we need a presubmit check to keep OS_IOS checks from sneaking back in.
,
Jun 22 2017
I'm not aware of anyone really maintaining it, it's more like anyone who wants to add or modify a check can do so themselves. If you look at CheckForInvalidOSMacros in PRESUBMIT.py you should get some idea about how to add the desired check. Then just send the CL to one of the OWNERS of PRESUBMIT.py.
,
Nov 10 2017
4 more months, a few more creeps in. https://chromium-review.googlesource.com/762873
,
Nov 10 2017
Eh, not that hard to augment CheckForInvalidOSMacros. Don't want to keep sending CLs to fix this.
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29278b40c52ed90f3ab2eef0ed9623ead9f18778 commit 29278b40c52ed90f3ab2eef0ed9623ead9f18778 Author: Lei Zhang <thestig@chromium.org> Date: Fri Nov 10 22:34:17 2017 Add a presubmit check to keep OS_IOS out of chrome/ BUG= 735628 Change-Id: I2eb4b87c86fbbd06c73ed6d1602c030b35d90d2a Reviewed-on: https://chromium-review.googlesource.com/762876 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#515718} [modify] https://crrev.com/29278b40c52ed90f3ab2eef0ed9623ead9f18778/chrome/PRESUBMIT.py [add] https://crrev.com/29278b40c52ed90f3ab2eef0ed9623ead9f18778/chrome/PRESUBMIT_test.py
,
Nov 10 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by kkhorimoto@chromium.org
, Jun 22 2017Owner: smut@chromium.org