New issue
Advanced search Search tips

Issue 735621 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_Success is flaky

Project Member Reported by xiy...@chromium.org, Jun 21 2017

Issue description

The test is flaky on try bots. Got hit a couple of times today.

e.g.
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/411808
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/411926

and one more:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/411964

This is one sample log that has some JS error. (The other two are not very informative).
[ RUN      ] EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_Success
HTTPS server started on 127.0.0.1:44321...
sending server_data: {"host": "127.0.0.1", "port": 44321} (36 bytes)
[10770:10853:0621/112126.618966:WARNING:freezer_cgroup_process_manager.cc(61)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
[10770:10770:0621/112127.246980:WARNING:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M65, around March 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source:  (0)
[10770:10770:0621/112127.415680:WARNING:CONSOLE(1)] "This file is deprecated. Please use `iron-flex-layout/iron-flex-layout-classes.html`, and one of the specific dom-modules instead", source: chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-shadow-flex-layout-extracted.js (1)
[10770:10770:0621/112127.435139:WARNING:CONSOLE(1)] "This file is deprecated. Please use `iron-flex-layout/iron-flex-layout-classes.html`, and one of the specific dom-modules instead", source: chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-flex-layout-extracted.js (1)
[10770:10770:0621/112129.006062:WARNING:CONSOLE(3866)] "/deep/ combinator is no longer supported in CSS dynamic profile. It is now effectively no-op, acting as if it were a descendant combinator. You should consider to remove it. See https://www.chromestatus.com/features/4964279606312960 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-extracted.js (3866)
[10770:10770:0621/112129.598452:ERROR:device_event_log_impl.cc(156)] [11:21:29.598] Network: network_state_handler.cc:160 SetTechnologyEnabled() called for the Tether DeviceState, but the current state was: 0
[10770:10770:0621/112129.605748:INFO:CONSOLE(8123)] "Loading asset bundle oauth-enrollment", source: chrome://oobe/oobe.js (8123)
[10770:10770:0621/112130.749242:INFO:CONSOLE(8107)] "Finished loading asset bundle oauth-enrollment", source: chrome://oobe/oobe.js (8107)
[10770:10770:0621/112130.804492:ERROR:CONSOLE(8640)] "TypeError: Cannot read property 'apply' of undefined
    at Object.api.(anonymous function) [as showStep] (chrome://oobe/oobe.js:416:42)
    at <anonymous>:1:29", source: chrome://oobe/oobe.js (8640)
[10770:10770:0621/112130.804685:ERROR:CONSOLE(416)] "Uncaught TypeError: Cannot read property 'apply' of undefined", source: chrome://oobe/oobe.js (416)
[10770:10770:0621/112130.843498:WARNING:enrollment_screen_handler.cc(442)] EnrollmentScreenHandler::UpdateState(): state=online, reason=update
[10770:10902:0621/112131.126698:WARNING:fake_gaia.cc(318)] Serving request /embedded/setup/chromeos
127.0.0.1 - - [21/Jun/2017 11:21:31] "GET /embedded/setup/chromeos?client_id=dummytoken&flow=enterprise HTTP/1.1" 200 -
[10770:10770:0621/112131.242971:WARNING:enrollment_screen.cc(295)] Device is successfully enrolled.
[10770:10770:0621/112131.243041:WARNING:enrollment_screen.cc(318)] The device attribute update is not permitted
../../chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc:341: Failure
Value of: IsStepDisplayed("success")
  Actual: false
Expected: true
../../chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc:342: Failure
Value of: IsStepDisplayed("error")
  Actual: true
Expected: false
[10770:10902:0621/112131.368379:ERROR:fake_gaia.cc(321)] Unhandled request /favicon.ico
[10770:10902:0621/112131.368466:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
127.0.0.1 - - [21/Jun/2017 11:21:31] "GET /favicon.ico HTTP/1.1" 404 -
[  FAILED  ] EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_Success, where TypeParam =  and GetParam() =  (5511 ms)

Picked JS error from above log (not sure whether it is the root cause tho since the other two fails without it):

[10770:10770:0621/112130.804492:ERROR:CONSOLE(8640)] "TypeError: Cannot read property 'apply' of undefined
    at Object.api.(anonymous function) [as showStep] (chrome://oobe/oobe.js:416:42)
    at <anonymous>:1:29", source: chrome://oobe/oobe.js (8640)
[10770:10770:0621/112130.804685:ERROR:CONSOLE(416)] "Uncaught TypeError: Cannot read property 'apply' of undefined", source: chrome://oobe/oobe.js (416)

Probably triggered from SetupActiveDirectoryJSNotifications in the test:
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc?rcl=fcd8fc688cf09e9a5cb2717d4fb8402c9f356edf&l=167


 

Comment 1 by vabr@chromium.org, Jun 22 2017

I am going to disable EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_Success and EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_UIErrors on CrOS. They also flake on Linux ChromiumOS MSan Tests, where also a use-of-uninitialized-value is reported (logs attached). Sample build: https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/1269
EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_Success.txt
19.0 KB View Download
EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_UIErrors.txt
35.8 KB View Download

Comment 2 by vabr@chromium.org, Jun 22 2017

Components: Enterprise>Enrollment
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5aaefd53aa22e0089c3e3a5f288be98c606a33df

commit 5aaefd53aa22e0089c3e3a5f288be98c606a33df
Author: Vaclav Brozek <vabr@chromium.org>
Date: Thu Jun 22 09:42:16 2017

Disable EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_*

They are flaky on CrOS bots, more info on the bug.

TBR=rsorokin@chromium.org
BUG= 735621 

Change-Id: I06a627bd3d7c042cd14833cf66a1c81c74488a1a
Reviewed-on: https://chromium-review.googlesource.com/544836
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481492}
[modify] https://crrev.com/5aaefd53aa22e0089c3e3a5f288be98c606a33df/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc

Comment 4 by ricea@google.com, Jun 22 2017

I have been reproducing with a local build, but it has been broken at least since June the 20th. I don't know why the bots didn't complain sooner. I'm still looking for an unbroken version.

Comment 5 by ricea@google.com, Jun 22 2017

It's been broken since at least March. I have given up on trying to bisect.

Comment 6 by vabr@chromium.org, Jun 22 2017

 Issue 735874  has been merged into this issue.
Status: Started (was: Assigned)
ricea@, how do you reproduce? For me it almost every time succeed. Do you use msan?
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f36ee305a5eade8537b964ee4d76cce8d48918e

commit 1f36ee305a5eade8537b964ee4d76cce8d48918e
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Tue Jun 27 15:28:20 2017

Chromad: Fix flakiness for TestActiveDirectoryEnrollment.*

Stress test shows no flakiness.

Bug:  735621 
Change-Id: Ibf30d16ffec50b9fb757ff7c39adc4017e465dc2
Reviewed-on: https://chromium-review.googlesource.com/544969
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482631}
[modify] https://crrev.com/1f36ee305a5eade8537b964ee4d76cce8d48918e/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment